From 0433643153775861318f75f39f655b6bde40aa57 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stanis=C5=82aw=20Chmiela?= Date: Fri, 20 Mar 2020 15:38:48 +0100 Subject: [PATCH] [expo-notifications] Small fixes (#7069) # Why Didn't want to put these changes inside another PR. # How - noticed a new version of `androidx:core` is available - noticed that `"sound":false` in the notification request made the notification play a sound # Test Plan None, it just works. --- packages/expo-notifications/android/build.gradle | 2 +- .../presentation/ExpoNotificationPresentationModule.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/expo-notifications/android/build.gradle b/packages/expo-notifications/android/build.gradle index aa493faf7bff0..0907417c2acda 100644 --- a/packages/expo-notifications/android/build.gradle +++ b/packages/expo-notifications/android/build.gradle @@ -66,7 +66,7 @@ dependencies { unimodule 'unimodules-permissions-interface' unimodule 'unimodules-image-loader-interface' - api 'androidx.core:core:1.1.0' + api 'androidx.core:core:1.2.0' api 'androidx.lifecycle:lifecycle-runtime:2.2.0' api 'androidx.lifecycle:lifecycle-process:2.2.0' api 'androidx.lifecycle:lifecycle-common-java8:2.2.0' diff --git a/packages/expo-notifications/android/src/main/java/expo/modules/notifications/notifications/presentation/ExpoNotificationPresentationModule.java b/packages/expo-notifications/android/src/main/java/expo/modules/notifications/notifications/presentation/ExpoNotificationPresentationModule.java index a45bd72bdbf00..aa08aaf07a982 100644 --- a/packages/expo-notifications/android/src/main/java/expo/modules/notifications/notifications/presentation/ExpoNotificationPresentationModule.java +++ b/packages/expo-notifications/android/src/main/java/expo/modules/notifications/notifications/presentation/ExpoNotificationPresentationModule.java @@ -42,7 +42,7 @@ protected void onReceiveResult(int resultCode, Bundle resultData) { if (resultCode == BaseNotificationsService.SUCCESS_CODE) { promise.resolve(null); } else { - Exception e = resultData.getParcelable(BaseNotificationsService.EXCEPTION_KEY); + Exception e = (Exception) resultData.getSerializable(BaseNotificationsService.EXCEPTION_KEY); promise.reject("ERR_NOTIFICATION_PRESENTATION_FAILED", "Notification could not be presented.", e); } }