Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

router.push and router.dismiss comments should be swapped #27691

Closed
ljukas opened this issue Mar 15, 2024 · 3 comments
Closed

router.push and router.dismiss comments should be swapped #27691

ljukas opened this issue Mar 15, 2024 · 3 comments
Labels
needs review Issue is ready to be reviewed by a maintainer Router expo-router

Comments

@ljukas
Copy link

ljukas commented Mar 15, 2024

Minimal reproducible example

Not needed

Which package manager are you using? (Yarn is recommended)

yarn

If the issue is web-related, please select the bundler (web.bundler in the app.json)

None

Summary

The comments for the router.push and router.dismiss functions seems the inverted, se screenshot

image

Environment

Not needed
@ljukas ljukas added needs validation Issue needs to be validated Router expo-router labels Mar 15, 2024
@expo-bot expo-bot added needs review Issue is ready to be reviewed by a maintainer and removed needs validation Issue needs to be validated labels Mar 15, 2024
@lucasvnborges
Copy link

could explain how you found this file?

@ljukas
Copy link
Author

ljukas commented Mar 18, 2024

Screen.Recording.2024-03-18.at.07.38.01.mov

I just ctrl+click router.navigate, se video. expo-router 3.4.8

@marklawlor
Copy link
Contributor

Fixed in #27412, should be in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs review Issue is ready to be reviewed by a maintainer Router expo-router
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@marklawlor @ljukas @lucasvnborges @expo-bot