Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] AuthSession's useAuthRequest's promptAsync accepts WebBrowser's AuthSessionOpenOptions #28333

Open
c5-ericlin opened this issue Apr 19, 2024 · 0 comments
Labels

Comments

@c5-ericlin
Copy link

Summary

We can see here and here that the options passed to promptAsync are (possibly augmented with url) and then passed to WebBrowser.openAuthSessionAsync. The docs (and corresponding Typescript types) currently indicate that the only options allowed in promptAsync (promptAsync under useAuthRequest) are AuthRequestPromptOptions, but more options are technically allowed given the code referenced above. The docs and Typescript types should also include the options listed under WebBrowser's AuthSessionOpenOptions as indicated by the docs for openAuthSessionAsync.

Link to the related docs page

https://docs.expo.dev/versions/latest/sdk/auth-session/

Anything else?

The typescript types are incorrect as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant