After Upgrade to SDK 33: undefined is not an object (evaluating '_expo Localization.Localization.locale') #5735

tinyGoldfish · 2019-09-22T22:14:06Z

🐛 Bug Report

Hello,

after Upgrading to SDK 33 I got the following error: "undefined is not an object (evaluating '_expo2.default.registerRootComponent), but before upgrade everything was fine. I got the below errors,

it first popped up this error:

then 3 seconds later changed to this:

Environment

Expo CLI 3.1.0 environment info:
System:
OS: macOS 10.14.6
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.16.0 - /usr/local/bin/node
Yarn: 1.17.0 - /usr/local/bin/yarn
npm: 6.11.3 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
IDEs:
Xcode: 10.3/10G8 - /usr/bin/xcodebuild
npmPackages:
expo: ^33.0.0 => 33.0.7
react: 16.8.3 => 16.8.3
react-native: https://github.com/expo/react-native/archive/sdk-33.0.0.tar.gz => 0.59.8
react-navigation: ^3.11.0 => 3.12.1
npmGlobalPackages:
expo-cli: 3.1.0

app's target: iOS

I just started learning Expo, please let me know if I need to provide more details.

Thanks very much,
SK

andersravn · 2019-09-23T05:47:39Z

Did you run expo install expo-localization and import it as import * as Localization from 'expo-localization';? As per the docs: https://docs.expo.io/versions/v33.0.0/sdk/localization/.

kevinvugts · 2019-09-23T06:59:50Z

Did you run expo install expo-localization and import it as import * as Localization from 'expo-localization';? As per the docs: https://docs.expo.io/versions/v33.0.0/sdk/localization/.

I also experiencing this error.

https://ibb.co/C5VGw0k

When is this on the pipeline to be fixed?

tsapeta · 2019-09-23T08:50:40Z

How do you import Localization module? Also, please remember about showing us an example code that will help us to reproduce the bug you're having.

slauzinho · 2019-09-23T09:09:26Z

I'm also having the same issue.

SDK 35
iOS 13
expo-localization: 7.0.0

Here is a code example:

import * as Localization from 'expo-localization';
const userLocaleCountryCode = Localization.country;

kevinvugts · 2019-09-23T09:13:02Z

How do you import Localization module? Also, please remember about showing us an example code that will help us to reproduce the bug you're having.

As you stated above.

Might be usefull while debugging

It all happened after upgrading to xcode 13

lukmccall · 2019-09-23T09:41:46Z

Hi @slauzinho, Localization.country was changed to Localization.region and it's only available on iOS (in SDK 35).

serhiipalash · 2019-09-23T09:42:06Z

It all happened after upgrading to xcode 13

I can confirm that this bug only happens in iOS 13 simulator and in iOS 12.2 simulator everything works fine. Plus, this bug affects not only SDK 33, but also 34 and 35.

In SDK 34 app crashes in this line https://github.com/expo/expo/blob/master/packages/expo-localization/build/Localization.js#L4

serhiipalash · 2019-09-23T09:45:16Z

It all happened after upgrading to xcode 13

@kevinvugts you can install iOS 12.2 in your new Xcode 13 and use its Simulator to continue your work today.

andersravn · 2019-09-23T10:10:12Z

Just to be clear. You guys mean Xcode 11 right? I guess you are confusing it with iOS 13.

kevinvugts · 2019-09-23T10:11:32Z

It all happened after upgrading to xcode 13

@kevinvugts you can install iOS 12.2 in your new Xcode 13 and use its Simulator to continue your work today.

Sure. Already did that. @andersravn I mean xCode 11 right. Sorry for the misconception

tinyGoldfish · 2019-09-23T10:34:17Z

Did you run expo install expo-localization and import it as import * as Localization from 'expo-localization';? As per the docs: https://docs.expo.io/versions/v33.0.0/sdk/localization/.

Yes I did, and I tried both iOS 13 and iOS 12.4.1 also not working.

lukmccall · 2019-09-23T11:42:02Z

I've created PR which may fix it.

However, it will be nice if you go to settings > general > language and region in your iOS simulator and update region setting. Then let me know if the Localization module starts working correctly.

serhiipalash · 2019-09-23T11:54:32Z

You guys mean Xcode 11 right?

Yes, we do. Sorry, I was confused with first message about it.

serhiipalash · 2019-09-23T12:50:40Z

However, it will be nice if you go to settings > general > language and region in your iOS simulator and update region setting. Then let me know if the Localization module starts working correctly.

It helps. After updating region all future app starts, even if you kill the simulator, don't crash.

tinyGoldfish · 2019-09-24T08:13:20Z

I've created PR which may fix it.

However, it will be nice if you go to settings > general > language and region in your iOS simulator and update region setting. Then let me know if the Localization module starts working correctly.

Hi thanks! But sorry it still does not work for me, I tried both on my iphones iOS 12.4.1 & iOS13, and iOS 12.2 simulator on Xcode, all still got the same error.

tinyGoldfish · 2019-09-24T11:02:07Z

I've created PR which may fix it.

However, it will be nice if you go to settings > general > language and region in your iOS simulator and update region setting. Then let me know if the Localization module starts working correctly.

Would there be any hot fixes for iphone testing directly as well? Many thanks!

lukmccall · 2019-09-25T11:59:22Z

Hi @tinyGoldfish, could you check if this bug occurred in iOS 13.1?
Please provide me with some information, because I'm struggling with reproducing this bug.

serhiipalash · 2019-09-25T12:02:59Z

@lukmccall there is no iOS 13.1 in Xcode 11, at least for now, but I tried to run our app in Expo app on my iPhone with iOS 13.1 and everything works fine. Also, as I understood, the bug happens only in iOS 13 Simulator.

serhiipalash · 2019-09-25T12:03:39Z

the bug happens only in iOS 13 Simulator.

not in standalone or Expo-client app

superKalo · 2019-09-25T12:13:45Z

@serhiipalash , it happens on our side too. Both - in simulator and Expo-client (on a real device). iOS 13.0. However, iOS 12 - all good.

Happens right after when you install the latest Expo-client on the simulator.

As soon as my code reaches this point: Localization.locale the error appears.

serhiipalash · 2019-09-25T12:16:02Z

@superKalo I've read your post and I don't see how it is related to this issue. This issue is about expo-localization module and not about react-native-svg, which is your post about.

superKalo · 2019-09-25T12:16:56Z

@superKalo I've read your post and I don't see how it is related to this issue. This issue is about expo-localization module and not about react-native-svg, which is your post about.

Sorry, I shared wrong issue. Please see my updated comment above.

tinyGoldfish · 2019-09-26T11:23:12Z

Hi @tinyGoldfish, could you check if this bug occurred in iOS 13.1?
Please provide me with some information, because I'm struggling with reproducing this bug.

Hi @lukmccall , thanks for the follow up, just tried again with the iOS 13.1 on my iphone, it's not working on my project neither...got the same error.
Yes sure, what kind of other information you would like me to provide? Thanks a lot!

superKalo · 2019-09-26T12:40:24Z

@lukmccall do you think this issue happens on iOS simulator (iOS v13.0) only?

I tried to publish same app (which displays this error) on a different release channel and I opened it on a real device (iPhone, iOS v13.0) via Expo-client. It works just fine. I wonder if this error will appear on the standalone app, if I decide to update.

bit-scrambler · 2019-09-26T15:17:44Z

As per my understanding the problem is that if the phone (either device or simulator) has the default language because the user didn't set it, all the language properties like timezone, country, currency and so on are undefined raising the exception
I'm able to reproduce the issue with iOS13 on a fresh simulator or on some devices.
Changing the language in "settings" to English/UK or English/US, the Localization.* properties are set properly.

lukmccall · 2019-09-27T12:04:51Z

@superKalo I think @bit-scrambler is right. This bug can occur not only in simulators.

For now, I've added a fallback value to locale property. Unfortunately, I don't know when a new version with the fix will be available.

serhiipalash · 2019-09-27T12:18:51Z

For now, I've added a fallback value to locale property.

@lukmccall do you mean that locale, timezone, currency properties could be undefined?

lukmccall · 2019-09-27T12:24:19Z

@serhiipalash, I was talking only about locale and locales properties. For some reason, iOS's function which should get system locale value return null.

serhiipalash · 2019-09-27T12:34:02Z

@lukmccall thanks for explanation, I just want to be sure that at least region still works and we can resolve app locale by region when user starts the app first time. Did you test region? Showing users app not in their native language will downgrade users retention a lot :(

lukmccall · 2019-09-27T12:48:31Z

@serhiipalashu unfortunately, region could fail too. Sorry for misleading you about this.

To sum everything up, locale, locales and region properties may not work correctly on iOS 13. I've added fallback values to locale and locales which should prevent an app from crashing. On the other hand, the region could be null.

For now, we should wait for a system patch.

jazzy-pm · 2019-10-03T11:08:22Z

I am using localization only for I18nManager. Below you can find the code. The above issue is only coming for iPhone pro 11 max and the other version before this are working fine.

import * as Localization from "expo-localization";
....
 loadFonts = async () => {
    await Font.loadAsync({
      icomoon: require("@assets/fonts/icomoon.ttf"),
      Roboto_medium: require("../node_modules/native-base/Fonts/Roboto_medium.ttf")
    });
    const { isRTL } = await Localization.getLocalizationAsync();
    I18nManager.forceRTL(isRTL);
    await I18n.initAsync();
  };
....

holgersindbaek · 2019-10-07T08:58:48Z

Can anyone confirm that this is NOT happening in production apps?

jacekd · 2019-10-07T09:09:06Z

@holgersindbaek I have an app in production and so far we have no problems with any of the iOS 13 devices.

# Why Resolve #5735. # How Wrapped `region` variable into UMNullIfNil macro, because `[[NSLocale currentLocale] objectForKey:NSLocaleCountryCode]` could return nil on iOS simulator.

morer62 · 2019-10-16T19:15:38Z

In your simulator go to settings > General > Language & Region and pick the United State as a region ...... If your region is already US, you have to click again in united States and Update

CruelMoney · 2019-12-11T12:44:43Z

Just got this on sdk 35 in the simulator, but after uograding to 36 it seems to be fixed 👌

feliperaul · 2020-01-12T15:37:53Z

@tsapeta Tomasz, won't this fix be backported to SDK 33, since it's still a supported SDK?

Just upgraded my XCode and I see the crash on my simulator.

Also, can the expo team confirm this won't affect real devices, only the simulator?

marcelxsilva · 2020-02-20T06:33:26Z

worked for me, here's what needs to be done: https://docs.expo.io/versions/latest/sdk/svg/

sarcadass · 2020-05-07T09:16:54Z

I still experience the problem here when I start a simulator for the first time without setting the region on the iPhone preferences. If the problem happen only on the Simulator it's not such a big deal as the solution is to set the region in the simulator preferences (even if a fix will be appreciated).
But if it happen too on real devices it's a critical bug, I don't have an iPhone on me so I can't test if the bug occur on real devices.

Is it possible to check if locale is not undefined before calling the replace() method?
And if locale is undefined you can fallback to English as it is the default language on the Simulator when you didn't set the region (locale = locale || 'en-en').

lukmccall · 2020-05-07T11:37:00Z

@sarcadass, #8193 should fix it ;)

drpiou · 2021-02-22T08:13:36Z

So, hum hum, SDK 40, just as simple as that with real iOS device:

import * as Localization from 'expo-localization';

console.log({ Localization });

throws : Cannot read property 'locale' of undefined.

And no, I didn't opened "Settings > General > Language & Region" because I do not expect my app users to do so on their side, it would be ugly to mention anything like that to anyone.

DamianBarrionuevo · 2021-08-30T21:44:35Z

I have a similar problem but I've been trying to fix it for a long time and I can't.
If they could help me they would save my time

dbalatoni13 · 2021-10-22T20:36:38Z

@DamianBarrionuevo I had the same problem on Android 11. The problem was that I forgot to rerun expo run:android after installing expo-localization.

tinyGoldfish added the bug label Sep 22, 2019

tinyGoldfish changed the title ~~undefined is not an object (evaluating '_expo Localization.Localization.locale')~~ After Upgrade to SDK 33: undefined is not an object (evaluating '_expo Localization.Localization.locale') Sep 22, 2019

tsapeta added the Localization label Sep 23, 2019

lukmccall self-assigned this Sep 23, 2019

lukmccall mentioned this issue Sep 23, 2019

[expo-localization] Fix constants exporting #5740

Merged

lukmccall mentioned this issue Sep 25, 2019

iOS 13: Expo-localization -> Cannot read property 'replace' of undefined #5768

Closed

kirill-dev-pro mentioned this issue Sep 26, 2019

Expo cant find StoreReview #5769

Closed

tomasvarga mentioned this issue Sep 26, 2019

NativeModules.SettingsManager.settings.AppleLocale not working in ios 13 facebook/react-native#26540

Closed

lukmccall mentioned this issue Oct 3, 2019

[localization] undefined is not an object (evaluating 'locale.replace') on iPhone pro 11 max #5850

Closed

tsapeta closed this as completed in #5740 Oct 15, 2019

lukmccall mentioned this issue May 7, 2020

[expo-localization][ios] Fix locale export #8193

Merged

After Upgrade to SDK 33: undefined is not an object (evaluating '_expo Localization.Localization.locale') #5735

After Upgrade to SDK 33: undefined is not an object (evaluating '_expo Localization.Localization.locale') #5735

Comments

tinyGoldfish commented Sep 22, 2019

🐛 Bug Report

Environment

andersravn commented Sep 23, 2019

kevinvugts commented Sep 23, 2019 • edited

tsapeta commented Sep 23, 2019 • edited

slauzinho commented Sep 23, 2019 • edited

kevinvugts commented Sep 23, 2019 • edited

Might be usefull while debugging

lukmccall commented Sep 23, 2019

serhiipalash commented Sep 23, 2019 • edited

serhiipalash commented Sep 23, 2019

andersravn commented Sep 23, 2019

kevinvugts commented Sep 23, 2019

tinyGoldfish commented Sep 23, 2019

lukmccall commented Sep 23, 2019

serhiipalash commented Sep 23, 2019

serhiipalash commented Sep 23, 2019

tinyGoldfish commented Sep 24, 2019

tinyGoldfish commented Sep 24, 2019

lukmccall commented Sep 25, 2019

serhiipalash commented Sep 25, 2019 • edited

serhiipalash commented Sep 25, 2019

superKalo commented Sep 25, 2019 • edited

serhiipalash commented Sep 25, 2019

superKalo commented Sep 25, 2019

tinyGoldfish commented Sep 26, 2019

superKalo commented Sep 26, 2019

bit-scrambler commented Sep 26, 2019

lukmccall commented Sep 27, 2019

serhiipalash commented Sep 27, 2019

lukmccall commented Sep 27, 2019

serhiipalash commented Sep 27, 2019

lukmccall commented Sep 27, 2019

jazzy-pm commented Oct 3, 2019

holgersindbaek commented Oct 7, 2019

jacekd commented Oct 7, 2019

morer62 commented Oct 16, 2019 • edited

CruelMoney commented Dec 11, 2019

feliperaul commented Jan 12, 2020

marcelxsilva commented Feb 20, 2020

sarcadass commented May 7, 2020

lukmccall commented May 7, 2020

drpiou commented Feb 22, 2021

DamianBarrionuevo commented Aug 30, 2021

dbalatoni13 commented Oct 22, 2021 • edited

kevinvugts commented Sep 23, 2019 •

edited

tsapeta commented Sep 23, 2019 •

edited

slauzinho commented Sep 23, 2019 •

edited

kevinvugts commented Sep 23, 2019 •

edited

serhiipalash commented Sep 23, 2019 •

edited

serhiipalash commented Sep 25, 2019 •

edited

superKalo commented Sep 25, 2019 •

edited

morer62 commented Oct 16, 2019 •

edited

dbalatoni13 commented Oct 22, 2021 •

edited