[expo-local-authentication] disableDeviceFallback option in android

[Jekiwijaya]

🐛 Bug Report

I think parameter disableDeviceFallback in LocalAuthentication. authenticateAsync(options) should also set false in android

expo/packages/expo-local-authentication/android/src/main/java/expo/modules/localauthentication/LocalAuthenticationModule.java

Line 142 in 936202c

.setDeviceCredentialAllowed(true)

Environment

Steps to Reproduce

Expected Behavior

when passing disableDeviceFallback true in android, also disable pin fallback in android

Actual Behavior

disableDeviceFallback only supported for ios

Reproducible Demo

[LinusU]

Just realised that I have already volunteered to submit a PR for this, but never got the time 😬

ref: #6891 (comment)

If anyone wants to pick it up, it should be pretty straight forward. When the option disableDeviceFallback is given as true, pass false to setDeviceCredentialAllowed instead of true. Please ping me if you submit a PR for this ☺️

[byCedric]

Fixed by #8219 🚀

[gie3d]

Hi @byCedric thank you very much. I'm really looking forward for that PR. Seen it's been merged but would this be release as part of the new expo version or this can be added the latest version manually? (I tried expo install expo-local-notification@9.1.1... but no luck 😥, it's still 9.0.0 )

Really appreciate if you could suggest

[byCedric]

Hi @gie3d! You should be able to install 9.1.1, outside the expo install command 😄 e.g. with yarn add expo-local-authentication@9.1.1. But be aware, this only works for bare workflow projects at the moment (includes native code changes). I'm afraid this change won't make SDK 37. We are currently testing and packing SDK 38, so most of our resources go to this now. We hope to get this out soon!