New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AV][Android] Fix AV progress update #7193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbarthec
suggested changes
Feb 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish we don't embed maintenance changes into PRs that solves issues 😉
packages/expo-av/android/src/main/java/expo/modules/av/progress/AndroidLooperTimeMachine.kt
Outdated
Show resolved
Hide resolved
packages/expo-av/android/src/main/java/expo/modules/av/progress/ProgressLooper.kt
Outdated
Show resolved
Hide resolved
packages/expo-av/android/src/test/java/expo/modules/av/progress/ProgressLooperTest.kt
Outdated
Show resolved
Hide resolved
packages/expo-av/android/src/main/java/expo/modules/av/progress/ProgressLooper.kt
Outdated
Show resolved
Hide resolved
packages/expo-av/android/src/main/java/expo/modules/av/progress/ProgressLooper.kt
Outdated
Show resolved
Hide resolved
packages/expo-av/android/src/main/java/expo/modules/av/progress/ProgressLooper.kt
Show resolved
Hide resolved
packages/expo-av/android/src/main/java/expo/modules/av/progress/ProgressLooper.kt
Show resolved
Hide resolved
mczernek
force-pushed
the
@mczernek/expo-av-progress-update
branch
from
February 27, 2020 09:32
4737006
to
4e27f3d
Compare
mczernek
force-pushed
the
@mczernek/expo-av-progress-update
branch
from
February 27, 2020 09:57
4e27f3d
to
be297d8
Compare
bbarthec
changed the title
@mczernek/expo av progress update
[AV][Android] Fix AV progress update
Feb 27, 2020
mczernek
force-pushed
the
@mczernek/expo-av-progress-update
branch
from
March 31, 2020 08:50
0a5141c
to
7cf077c
Compare
bbarthec
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯 only this one small change in CHANGELOG
💅 😉
mczernek
force-pushed
the
@mczernek/expo-av-progress-update
branch
from
April 1, 2020 08:01
c8c3cc4
to
4acfdb8
Compare
bbarthec
approved these changes
Apr 1, 2020
Co-Authored-By: Bartłomiej Bukowski <bartlomiejbukowski.b@gmail.com>
mczernek
force-pushed
the
@mczernek/expo-av-progress-update
branch
from
April 15, 2020 09:02
4acfdb8
to
62b858c
Compare
This was referenced Aug 4, 2020
Jamedjo
pushed a commit
to Jamedjo/expo
that referenced
this pull request
Feb 4, 2021
Co-Authored-By: Bartłomiej Bukowski <bartlomiejbukowski.b@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Resolves #6342