Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web browser improvements #7221

Merged
merged 10 commits into from Mar 4, 2020
Merged

Web browser improvements #7221

merged 10 commits into from Mar 4, 2020

Conversation

mczernek
Copy link
Contributor

Why

Thanks @LinusU for adding new features to WebBrowser. We can now enable reader mode in iOS and default share button in menu on Android.

@ExpoBot
Copy link

ExpoBot commented Feb 28, 2020

Warnings
⚠️

You modified sdk/webbrowser.md in the unversioned directory. Please consider copying the changes to the latest released version if applicable.

Generated by 🚫 dangerJS against 59dee9e

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! 👍

- **package (_optional_) (_string_)** -- (_Android only_). Package name of a browser to be used to handle Custom Tabs. List of available packages is to be queried by [getCustomTabsSupportingBrowsers](#webbrowsergetcustomtabssupportingbrowsers) method.
- **readerMode (_optional_) (_boolean_)** -- (_iOS only_) a boolean determining whether Safari should enter Reader mode, if it is available.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should make it a mode: "default" | "reader"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like a boolean in here, since it reflects exactly native API.

packages/expo-web-browser/ios/EXWebBrowser/EXWebBrowser.m Outdated Show resolved Hide resolved
@mczernek mczernek force-pushed the LinusU/web-browser-improvements branch from 4d1427b to 59dee9e Compare March 4, 2020 15:18
@mczernek mczernek merged commit e76d362 into master Mar 4, 2020
@mczernek mczernek deleted the LinusU/web-browser-improvements branch March 4, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants