Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip font loading whenever userAgent is Firefox #7420

Merged
merged 1 commit into from Mar 20, 2020
Merged

Skip font loading whenever userAgent is Firefox #7420

merged 1 commit into from Mar 20, 2020

Conversation

mauriciord
Copy link
Contributor

Why

Fix #6940 (comment)

How

Skip whenever userAgent is Firefox

Test Plan

Test NCL on Firefox browser

@mauriciord mauriciord mentioned this pull request Mar 20, 2020
Closed
EvanBacon
EvanBacon approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@EvanBacon EvanBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Maybe we should configure this to only load in chrome.

@EvanBacon EvanBacon merged commit 9fe1874 into expo:master Mar 20, 2020
@EvanBacon EvanBacon self-assigned this Mar 20, 2020
@EvanBacon EvanBacon added bug Font Platform: web Using Expo in the browser labels Mar 20, 2020
@mauriciord mauriciord deleted the expo-font/fix-firefox-bug branch March 20, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanBacon EvanBacon EvanBacon approved these changes

@sjchmiela sjchmiela Awaiting requested review from sjchmiela

Assignees

@EvanBacon EvanBacon

Labels
bug Font Platform: web Using Expo in the browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Font.loadAsync failing on safari (and mobile safari) in web
2 participants
@mauriciord @EvanBacon