[gl] Improved logging options in expo-gl
#7550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkozyra95
approved these changes
Apr 1, 2020
bbarthec
approved these changes
Apr 1, 2020
packages/expo-gl/src/GLUtils.ts
Outdated
|
|
||
| // Turn off logging. | ||
| if (!option || option === GLLoggingOption.DISABLED) { | ||
| Object.keys(gl).forEach(key => { |
There was a problem hiding this comment.
Why not Object.entries 🤔 ?
packages/expo-gl/src/GLUtils.ts
Outdated
| } | ||
|
|
||
| // Turn on logging. | ||
| Object.keys(gl).forEach(key => { |
There was a problem hiding this comment.
Same here: Object.entries?
tsapeta
force-pushed
the
@tsapeta/gl-improved-logging
branch
from
882ffa5
to
514ccbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
#7502 reminded me that we should have better logging/debugging options for
expo-glas we don't log anything by default and, most importantly, we don't log any errors like all web browsers do.How
gl.enableLogging-> it isn't a part of WebGL specification so imho it should somehow indicate itself as Expo-specific. We don't need to deprecate it first as it wasn't documented.gl.__expoSetLoggingmethod which receives bitwise enumGLLoggingOption(check out tsdoc comments for more details).GLUtils, because I believe we can put more stuff there soon).[object Object].Test Plan
Tested by adding
gl.__expoSetLoggingmethod call to NCL example and playing with some customGLLoggingOptionvalues.