[expo-av] Add return type to loadAsync() #7559
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE/EDIT
I just realized this was happening because in SDK 36, the PlaybackStatus type wasnt exported so i was importing directly from
expo-av/src/AV
. If I switch to import from the top level packageexpo-av
then the compliation error goes away. That said, I believe this code change is still correctWhy
In my project I use typescript's
noImplicitAny: true
option. It causesloadAsync
to show as a typechecking error.How
The docs say that loadAsync returns a Promise. https://docs.expo.io/versions/v37.0.0/sdk/av/#playback-api
Test Plan
If I use this patch locally, the compilation error goes away