Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Remove dispatch_once_t used as a member instance #7576

Merged
merged 5 commits into from Apr 29, 2020

Conversation

sjchmiela
Copy link
Contributor

Why

While investigating reasons for #7562 I found out it's not recommended to use dispatch_once_t as a property.

How

  • removed all dispatch_once_t uses in favor of simple if (!…) { … =

Test Plan

Expo client compiled, running native-component-list#Permissions screen worked ok.

@bbarthec
Copy link
Contributor

bbarthec commented Apr 2, 2020

You probably have to rebase it to make CI pass 😉

@sjchmiela sjchmiela force-pushed the @sjchmiela/fix-expo-permissions-crash branch from d08b03c to ca9a39c Compare April 29, 2020 11:56
@sjchmiela sjchmiela merged commit 0dddd79 into master Apr 29, 2020
@sjchmiela sjchmiela deleted the @sjchmiela/fix-expo-permissions-crash branch April 29, 2020 11:57
@github-actions
Copy link
Contributor

Native Component List for this branch is ready



Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants