[expo-auth-session] Fix release channel support #7687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukmccall - can you write a test to cover this case? |
bbarthec
approved these changes
Apr 9, 2020
lukmccall
force-pushed
the
@lukmccall/auth-session-fix-support-for-release-channels
branch
from
5d7d32a
to
2b9788f
Compare
tsapeta
approved these changes
Apr 9, 2020
lukmccall
deleted the
@lukmccall/auth-session-fix-support-for-release-channels
branch
brentvatne
pushed a commit
that referenced
this pull request
Apr 16, 2020
* [expo-auth-session] Fix release channel support * [expo-auth-session] Update changelog * [expo-auth-session] Fix typo * [expo-auth-session] Add tests
|
this is available in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Resolves #7674.
How
Fixes
AuthSession.getDefaultReturnUrl()Test Plan
adb shell am start -d <result of AuthSession.getDefaultReturnUrl()>(for me: "exp://exp.host/@lukaszkosmaty/sandbox/--/expo-auth-session?release-channel=releases-test")