Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android][navigation bar] re-apply full screen config on window focus #7770

Merged
merged 3 commits into from Apr 10, 2020

Conversation

cruzach
Copy link
Contributor

@cruzach cruzach commented Apr 9, 2020

Why

Nav bar customizations added in #7049 aren't re-applied when you background and foreground the app
closes #7663

How

added onWindowFocusChanged, setting the navbar style again on focus

Test Plan

Tested in local client build and shell app build: leanback, immersive, and sticky-immersive all result in expected behavior

@cruzach cruzach requested a review from bbarthec April 9, 2020 14:45
Copy link
Contributor

@bbarthec bbarthec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 Some CHANGELOG entry would be beneficial 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants