Add UMFileSystemInterface dependency to expo-media-library podspec #7861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukmccall
changed the title
sjchmiela
approved these changes
Apr 17, 2020
There was a problem hiding this comment.
Could you also add a dependency on unimodules-filesystem-interface to media-library's package.json, please? 🙏 (I know that the unimodulePeerDependencies property doesn't do anything right now, but as we decide to fix it we will want to do this in some batch form without having to think about whether any dependency should be added to the particular package.)
lukmccall
force-pushed
the
@lukmccall/@ashoat/fix-dependency
branch
from
b735289
to
79e11d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Follow up to the #7809.