Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expo] Remove unused takeSnapshotAsync web code #7950

Merged
merged 2 commits into from Apr 21, 2020
Merged

[expo] Remove unused takeSnapshotAsync web code #7950

merged 2 commits into from Apr 21, 2020

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Apr 21, 2020 •
edited

Why

The export seems to have been removed but the web code was never deleted.

This causes what may be a breaking change in the sense that react-native-view-shot is not installed by default in expo apps now.

Large reduction:

- package size: 112.5 kB
- unpacked size: 466.7 kB

+ unpacked size: 96.1 kB
+ unpacked size: 406.6 kB

@EvanBacon EvanBacon added the Platform: web Using Expo in the browser label Apr 21, 2020
@EvanBacon EvanBacon self-assigned this Apr 21, 2020
@ide
Copy link
Member

ide commented Apr 21, 2020

Can you also add a CHANGELOG entry that mentions this?

@EvanBacon EvanBacon changed the title Remove unused takeSnapshotAsync web code [expo] Remove unused takeSnapshotAsync web code Apr 21, 2020
@EvanBacon EvanBacon merged commit 040b6d9 into master Apr 21, 2020
@EvanBacon EvanBacon deleted the @evanbacon/expo/remove-web-takeSnapshotAsync branch April 21, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentvatne brentvatne brentvatne approved these changes

@esamelson esamelson Awaiting requested review from esamelson

@ide ide Awaiting requested review from ide ide is a code owner

@tsapeta tsapeta Awaiting requested review from tsapeta tsapeta is a code owner

Assignees

@EvanBacon EvanBacon

Labels
Platform: web Using Expo in the browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EvanBacon @ide @brentvatne