Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expo-permissions] Fix permissions in the headless mode #7962

Merged
merged 4 commits into from Apr 28, 2020
Merged

[expo-permissions] Fix permissions in the headless mode #7962

merged 4 commits into from Apr 28, 2020

Conversation

lukmccall
Copy link
Contributor

Why

Resolves #7456.

How

  • fallback to the application context when the current activity is null.

Test Plan

@lukmccall lukmccall requested a review from mczernek April 22, 2020 17:00
bbarthec
bbarthec reviewed Apr 23, 2020
View reviewed changes
Copy link
Contributor

@bbarthec bbarthec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😉

...view/src/main/java/versioned/host/exp/exponent/modules/universal/ScopedPermissionsService.kt Outdated Show resolved Hide resolved
android/expoview/src/main/java/host/exp/exponent/experience/ReactNativeActivity.java Outdated Show resolved Hide resolved
android/expoview/src/main/java/host/exp/exponent/kernel/services/PermissionsKernelService.java Outdated Show resolved Hide resolved
@lukmccall lukmccall requested a review from bbarthec April 23, 2020 10:42
mczernek
mczernek approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@mczernek mczernek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@lukmccall lukmccall force-pushed the @lukmccall/expo-permissions-fix-in-headless branch from 0356d25 to 6909239 Compare April 27, 2020 10:17
@lukmccall lukmccall force-pushed the @lukmccall/expo-permissions-fix-in-headless branch 5 times, most recently from 73057ca to d2a6a6f Compare April 27, 2020 15:03
@lukmccall lukmccall force-pushed the @lukmccall/expo-permissions-fix-in-headless branch from d2a6a6f to 644c0fb Compare April 27, 2020 15:04
@lukmccall lukmccall merged commit 4b8fd15 into master Apr 28, 2020
@lukmccall lukmccall deleted the @lukmccall/expo-permissions-fix-in-headless branch April 28, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mczernek mczernek mczernek approved these changes

@bbarthec bbarthec bbarthec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing CAMERA_ROLL permissions when running in headless mode
3 participants
@lukmccall @mczernek @bbarthec