New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[expo-sms] Adds Attachment Support To Add Images To SMS Messages #7967
Conversation
4c355dc
to
ef5e254
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Please add docs and let's make it mergeable! 😊
ef5e254
to
3103f14
Compare
remoteUri: 'https://upload.wikimedia.org/wikipedia/commons/2/2c/Rotating_earth_%28large%29.gif', | ||
md5: '090592ebd01ac1e425b2766989040f80', | ||
mimeType: 'image/gif', | ||
}; | ||
|
||
const audioFile = { | ||
localUri: FS.documentDirectory + 'sound.mp3', | ||
remoteUri: 'https://dl.espressif.com/dl/audio/gs-16b-1c-44100hz.mp3', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EvanBacon @bbarthec - would one of y'all be able to upload these to the test-suite-data
S3 bucket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can change after merged
3103f14
to
e2d71a3
Compare
Updated to wrap the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this
Why
The Expo SMS package currently does not support image attachments.
How
Adds support for both iOS and Android to share an image attachment (png or jpeg) alongside the message.
Note: I would appreciate any feedback on this. If you are open to merging this in, I'll update the documentation as well.
Test Plan
Added tests to both iOS and Android test suite to validate the functionality.