Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-updates][ios] Add segmented control for iOS 13 #8038

Merged
merged 5 commits into from May 22, 2020

Conversation

marchenk0va
Copy link
Contributor

@marchenk0va marchenk0va commented Apr 27, 2020

Why

SegmentedControlIOS is deprecated in react-native. Documentation says to use @react-native-community/segmented-control instead.

Issue #7978

How

Installed @react-native-community/segmented-control.

Test Plan

Changes should be tested in expo app. Use SegmentedControl from @react-native-community/segmented-control and run.

@tsapeta
Copy link
Member

tsapeta commented Apr 27, 2020

Hey @marchenk0va, thanks for your contribution! 🙇

Unfortunately, it's not enough to make @react-native-community/segmented-control available in managed Expo workflow. Because of versioning and supporting multiple SDK versions at once, we have to pull in the native code of 3rd-party libraries to our repository.
We used to be running et update-vendored-module -m <module_name_to_update> command to update those libraries, however since it's not pulled and configured yet, you would have to modify the configuration, see @react-native-community/datetimepicker for reference:

'@react-native-community/datetimepicker': {
repoUrl: 'https://github.com/react-native-community/react-native-datetimepicker.git',
installableInManagedApps: true,
steps: [
{
sourceIosPath: 'ios',
targetIosPath: 'Api/Components/DateTimePicker',
sourceAndroidPath: 'android/src/main/java/com/reactcommunity/rndatetimepicker',
targetAndroidPath: 'modules/api/components/datetimepicker',
sourceAndroidPackage: 'com.reactcommunity.rndatetimepicker',
targetAndroidPackage: 'versioned.host.exp.exponent.modules.api.components.datetimepicker',
},
],
},

Let me know if you need any more help!

@marchenk0va marchenk0va closed this May 7, 2020
@marchenk0va marchenk0va reopened this May 7, 2020
@marchenk0va
Copy link
Contributor Author

@tsapeta I added segmented-control on the reference to datetimepicker, thanks for help! Have questions about web test suites, I am trying to fix errors but tests seems flaky. Is it the case after adding lib or it's regular issue?

@marchenk0va marchenk0va changed the title [ios] Add segmented control for iOS 13 [expo-updates][ios] Add segmented control for iOS 13 May 7, 2020
Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇‍♂️ Sorry for the delay – I'm gonna merge it right now so it'll be included in SDK38 😉 I'll also take care of updating it again to the latest possible version.

@tsapeta tsapeta merged commit 75490e9 into expo:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants