[segment] unify native initialization methods #8046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
sjchmiela
approved these changes
May 20, 2020
| AROrientationTrackingConfiguration: { type: 'boolean', mock: false }, | ||
| ARWorldTrackingConfiguration: { type: 'boolean', mock: false }, | ||
| AROrientationTrackingConfiguration: { type: 'boolean', mock: true }, | ||
| ARWorldTrackingConfiguration: { type: 'boolean', mock: true }, |
There was a problem hiding this comment.
I try to not modify those mocks files when I commit this file, otherwise every other person regenerating it in a different environment would always change this, status bar height, deviceYearClass etc. But that's just a suggestion!
There was a problem hiding this comment.
ah that's a good call, thanks!
cruzach
force-pushed
the
@cruzach/segment-api
branch
from
b185757
to
4274168
Compare
|
Native Component List for this branch is ready |
This was referenced May 29, 2021
This was referenced Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Most of our other APIs have the same method names across Android/iOS so we can reduce our JS code. This PR also handles the case where either an empty object is provided, or write keys are unknowingly
nullwhen passed in (happened to a partner of ours) resulting in the Expo Client (or standalones) crashingHow
Rename methods & re-mock NativeModules
Test Plan
added/rewrote tests