[@unimodules/core] Add support for null values to @unimodules/core and expo-notifications #8153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
sjchmiela
force-pushed
the
@sjchmiela/unimodules-core-json-arguments
branch
from
9bf00c9
to
31a70f0
Compare
sjchmiela
changed the title
sjchmiela
force-pushed
the
@sjchmiela/unimodules-core-json-arguments
branch
from
31a70f0
to
13d0eb8
Compare
tsapeta
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #8142 (comment).
How
Added support for
nullvalues toexpo-notificationsand@unimodules/core. Also, moved helper methods implementations to interface.Test Plan
Added more coverage to
test-suitewhich confirmed that the fix is correct.