[react-native] Upgrade to 0.62.2 #8310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
sjchmiela
force-pushed
the
@sjchmiela/reactnative-0.62.2
branch
3 times, most recently
from
b193944
to
b8a0d96
Compare
sjchmiela
requested review from
bbarthec,
brentvatne,
EvanBacon,
ide,
IjzerenHein and
tsapeta
as code owners
|
Some of the commits may be left not-reviewed as they are effect of automated processes. Some changes worth reviewing are:
|
|
For the react-native branch, to keep things organized we have several The LogBox fix seems OK for now, but reaffirms that replacing the various devtools and devsupport classes will likely make the platform more stable. Not versioning JNI seems simplest for now. I do want to be careful, though, because needing to patch several modules is not sustainable. The symbolicateStackTrace change looks fine to me. I left some small inline comments. Make sure the unit tests continue to pass or update them if needed. Removing the custom Yarn package resolution is fantastic. Thank you. |
ide
reviewed
May 20, 2020
bbarthec
reviewed
May 20, 2020
| @@ -98,15 +98,15 @@ | |||
|
|
|||
| <activity | |||
| android:name=".experience.ExperienceActivity" | |||
| android:configChanges="keyboard|keyboardHidden|orientation|screenSize" | |||
| android:configChanges="keyboard|keyboardHidden|orientation|screenSize|uiMode" | |||
There was a problem hiding this comment.
Ok, so this change will have to be inspected from the perspective of react-native-appearance 🤔
I'm not sure whether react-native-appearance can handle it properly (change from recreating whole activity to fire some lifecycle method upon change)? cc @brentvatne
bbarthec
reviewed
May 20, 2020
tsapeta
reviewed
May 20, 2020
sjchmiela
force-pushed
the
@sjchmiela/reactnative-0.62.2
branch
from
b8a0d96
to
bd53b8b
Compare
🛠 Suggested fixes:📋 Missing changelogApply suggested changes:diff --git a/packages/expo-gl/CHANGELOG.md b/packages/expo-gl/CHANGELOG.md
index ec77c1295a..5c460f9bc1 100644
--- a/packages/expo-gl/CHANGELOG.md
+++ b/packages/expo-gl/CHANGELOG.md
@@ -8,6 +8,8 @@
### 🐛 Bug fixes
+- Upgrade to 0.62.2 ([#8310](https://github.com/expo/expo/pull/8310) by [@sjchmiela](https://github.com/sjchmiela))
+
## 8.2.0
### 🎉 New features |
|
|
tsapeta
approved these changes
May 22, 2020
sjchmiela
force-pushed
the
@sjchmiela/reactnative-0.62.2
branch
from
95d92b1
to
e6a819f
Compare
Importing change made to React Native example apps in facebook/react-native#26413
JNI has been extracted to FBJNI package and it has become very difficult to version properly. Let's try to share one version of JNI between all future React Natives and hope that we can monkey-patch any non-backwards compatible changes thanks to access to source code at facebookincubator/fbjni.
…orm-ios No longer needed, `pod install` in `apps/bare-expo/ios` succeeded
…ateStackTrace return)
sjchmiela
force-pushed
the
@sjchmiela/reactnative-0.62.2
branch
from
e6a819f
to
adc6747
Compare
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Jul 16, 2020
A reversion of e40c020 and 62621ef. Unfortunately, Jest 26 (the latest), which we'll take in an upcoming commit, doesn't support `jest-expo` at 37 [1]. We can't go past 37 (e.g., to 38.0.2, the latest) until we upgrade to React Native v0.62 (that's zulip#3782). That's because jest-expo's "react" peer dependency was bumped from ~16.9.0 to ~16.11.0 in expo/expo#8310 [2], and we must do that React upgrade atomically with our RN upgrade. The "react-native" peer dependency wasn't touched; it remained at "*". So, I'm left unsure whether it was intentional to drop support for RN v0.61 [3]. Ah well. As we were aware in e40c020: """ If `jest-expo` turns out to be buggy, or the dependency requirements get even more tangled or burdensome, we should feel free to abandon this effort; it's not terrible to have to add boring mocks. """ We may consider adding it back in as a followup to zulip#3782. Run our usual `yarn yarn-deduplicate && yarn`, as prompted by `tools/test deps`. [1] We get errors about jest-expo using `require.requireActual`, which was removed in jestjs/jest#9854, out in v26.0.0-alpha.0. [2] expo/expo@a4cabf30a#diff-4a85ebd1069aff25ee2e5f2b004281ccR33 [3] See react-native-webview/react-native-webview#1445.
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Aug 12, 2020
A reversion of e40c020 and 62621ef. Unfortunately, Jest 26 (the latest), which we'll take in an upcoming commit, doesn't support `jest-expo` at 37 [1]. We can't go past 37 (e.g., to 38.0.2, the latest) until we upgrade to React Native v0.62 (that's zulip#3782). That's because jest-expo's "react" peer dependency was bumped from ~16.9.0 to ~16.11.0 in expo/expo#8310 [2], and we must do that React upgrade atomically with our RN upgrade. The "react-native" peer dependency wasn't touched; it remained at "*". So, I'm left unsure whether it was intentional to drop support for RN v0.61 [3]. Ah, well. As I said in e40c020: """ If `jest-expo` turns out to be buggy, or the dependency requirements get even more tangled or burdensome, we should feel free to abandon this effort; it's not terrible to have to add boring mocks. """ We may consider adding it back in as a followup to zulip#3782. Run our usual `yarn yarn-deduplicate && yarn`, as prompted by `tools/test deps`. [1] We get errors about jest-expo using `require.requireActual`, which was removed in jestjs/jest#9854, out in v26.0.0-alpha.0. [2] expo/expo@a4cabf30a#diff-4a85ebd1069aff25ee2e5f2b004281ccR33 [3] See react-native-webview/react-native-webview#1445.
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Aug 14, 2020
A reversion of e40c020 and 62621ef. Unfortunately, Jest 26 (the latest), which we'll take in an upcoming commit, doesn't support `jest-expo` at 37 [1]. We can't go past 37 (e.g., to 38.0.2, the latest) until we upgrade to React Native v0.62 (that's zulip#3782). That's because jest-expo's "react" peer dependency was bumped from ~16.9.0 to ~16.11.0 in expo/expo#8310 [2], and we must do that React upgrade atomically with our RN upgrade. The "react-native" peer dependency wasn't touched; it remained at "*". So, I'm left unsure whether it was intentional to drop support for RN v0.61 [3]. Ah, well. As I said in e40c020: """ If `jest-expo` turns out to be buggy, or the dependency requirements get even more tangled or burdensome, we should feel free to abandon this effort; it's not terrible to have to add boring mocks. """ We may consider adding it back in as a followup to zulip#3782. Run our usual `yarn yarn-deduplicate && yarn`, as prompted by `tools/test deps`. [1] We get errors about jest-expo using `require.requireActual`, which was removed in jestjs/jest#9854, out in v26.0.0-alpha.0. [2] expo/expo@a4cabf30a#diff-4a85ebd1069aff25ee2e5f2b004281ccR33 [3] See react-native-webview/react-native-webview#1445.
prakashbask
pushed a commit
to prakashbask/expo
that referenced
this pull request
Mar 16, 2022
# Why Let's have latest React Native in the upcoming SDK! # How See the story at https://www.notion.so/expo/React-Native-Upgrade-Diary-947bc0b506a942189fd47ff6e53bf95b. # Test Plan Expo Client runs, versioned SDK38 also runs (after a couple of post-version fixes outlined in the aforementioned doc). `expo-cli` can't handle `client_log` events, but that's something we may want to figure out after merging this PR, I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Let's have latest React Native in the upcoming SDK!
How
See the story at https://www.notion.so/expo/React-Native-Upgrade-Diary-947bc0b506a942189fd47ff6e53bf95b.
Test Plan
Expo Client runs, versioned SDK38 also runs (after a couple of post-version fixes outlined in the aforementioned doc).
expo-clican't handleclient_logevents, but that's something we may want to figure out after merging this PR, I guess.