From b263d45171637d1529153622b26f21489a8ae0d6 Mon Sep 17 00:00:00 2001 From: Hein Rutjes Date: Mon, 18 May 2020 11:50:45 +0200 Subject: [PATCH 1/3] [expo-av][ios] Fix BOOL usage --- packages/expo-av/ios/EXAV/Video/EXVideoView.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/expo-av/ios/EXAV/Video/EXVideoView.m b/packages/expo-av/ios/EXAV/Video/EXVideoView.m index a60a7715e7790..d5986de950a96 100644 --- a/packages/expo-av/ios/EXAV/Video/EXVideoView.m +++ b/packages/expo-av/ios/EXAV/Video/EXVideoView.m @@ -245,12 +245,12 @@ - (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(N if (viewBounds.size.height != screen.size.height && viewBounds.size.width != screen.size.width && _fullscreenPlayerPresented) { // Fullscreen player is being dismissed - _fullscreenPlayerPresented = false; + _fullscreenPlayerPresented = NO; [self _callFullscreenCallbackForUpdate:EXVideoFullscreenUpdatePlayerWillDismiss]; [self _callFullscreenCallbackForUpdate:EXVideoFullscreenUpdatePlayerDidDismiss]; } else if (viewBounds.size.height == screen.size.height && viewBounds.size.width == screen.size.width && !_fullscreenPlayerPresented) { // Fullscreen player is being presented - _fullscreenPlayerPresented = true; + _fullscreenPlayerPresented = YES; [self _callFullscreenCallbackForUpdate:EXVideoFullscreenUpdatePlayerWillPresent]; [self _callFullscreenCallbackForUpdate:EXVideoFullscreenUpdatePlayerDidPresent]; } else { From 19bfd92bd30eddd4f118ca7f4451d8e2106b67d1 Mon Sep 17 00:00:00 2001 From: Hein Rutjes Date: Mon, 18 May 2020 12:28:54 +0200 Subject: [PATCH 2/3] [video][ios] Fix unable to call presentFullScreenPlayer twice MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes an issue when calling `presentFullScreenPlayer` more than once on iOS. This would result in the error “Fullscreen player is already being presented” when the `useNativeControls` prop also set on the `