[expo-av][android] fix for exo player video bandwidth #8363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass bandwidth listener through to datasource factory and set using addTransferListener when not null
watchinharrison
force-pushed
the
bandwidth-meter-transfer-listener
branch
from
c34253a
to
4fbf05a
Compare
watchinharrison
changed the title
watchinharrison
changed the title
mczernek
reviewed
May 20, 2020
...id/src/main/java/expo/modules/av/player/datasource/CustomHeadersOkHttpDataSourceFactory.java
Outdated
Show resolved
Hide resolved
mczernek
reviewed
May 20, 2020
...po-av/android/src/main/java/expo/modules/av/player/datasource/DataSourceFactoryProvider.java
Outdated
Show resolved
Hide resolved
createFactory override now contains TransferListener
watchinharrison
force-pushed
the
bandwidth-meter-transfer-listener
branch
from
2dfa796
to
2e37c36
Compare
|
Changes are included in #8380, so closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
as described in #2177 android videos don't adapt to bandwidth when using an m3u8 adaptive stream file. This means they remain at the lowest quality
How
Passing through the bandwidthMeter transfer listener to the OkHttpDataSource instance to be set via
addTransferListenerTest Plan
View a .m3u8 uri video and see the quality of the video improve, existing videos continue to work as expected
Before:
Before.mov.zip
After:
After.mov.zip