@mczernek/app loader migration #8438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
sjchmiela
approved these changes
May 22, 2020
packages/@unimodules/react-native-adapter/android/src/main/AndroidManifest.xml
Show resolved
Hide resolved
🛠 Suggested fixes:📋 Missing changelogApply suggested changes:diff --git a/packages/unimodules-app-loader/CHANGELOG.md b/packages/unimodules-app-loader/CHANGELOG.md
index e23a2d85f6..e0e228f655 100644
--- a/packages/unimodules-app-loader/CHANGELOG.md
+++ b/packages/unimodules-app-loader/CHANGELOG.md
@@ -8,4 +8,5 @@
### 🐛 Bug fixes
+- @mczernek/app loader migration. ([#8438](https://github.com/expo/expo/pull/8438) by [@mczernek](https://github.com/mczernek))
- Fixed `appLoaderRegisteredForName` to not only check if a loader class name is in the cache for the provided name but also verifies that the cached and current class name match. When migrating from managed to bare, the class name cache needs to be updated. ([#8292](https://github.com/expo/expo/pull/8292) by [@thorbenprimke](https://github.com/thorbenprimke)) |
tsapeta
approved these changes
May 25, 2020
…nsume it in AppLoaderProvider.
…ting in the meantime.
mczernek
force-pushed
the
@mczernek/app-loader-migration
branch
from
4156f32
to
d45b44f
Compare
🛠 Suggested fixes:📋 Missing changelogApply suggested changes:diff --git a/packages/unimodules-app-loader/CHANGELOG.md b/packages/unimodules-app-loader/CHANGELOG.md
index 0b0d87d5..754689d2 100644
--- a/packages/unimodules-app-loader/CHANGELOG.md
+++ b/packages/unimodules-app-loader/CHANGELOG.md
@@ -8,6 +8,8 @@
### 🐛 Bug fixes
+- @mczernek/app loader migration ([#8438](https://github.com/expo/expo/pull/8438) by [@mczernek](https://github.com/mczernek))
+
## 1.1.0 — 2020-05-27
### 🐛 Bug fixesor merge this pull request: #8517 |
tsapeta
requested changes
May 27, 2020
There was a problem hiding this comment.
Sooo many hacks there 😞 But looks like there is no better way right now 😞
Left a few comments, but besides of them
- All those new files could use Kotlin 😄
- Would be great if you could add some comments around those repository classes & methods and especially in places where we do these hacks
packages/expo-task-manager/android/src/main/java/expo/modules/taskManager/TaskService.java
Outdated
Show resolved
Hide resolved
.../android/src/main/java/expo/modules/taskManager/repository/BareTasksAndEventsRepository.java
Outdated
Show resolved
Hide resolved
.../android/src/main/java/expo/modules/taskManager/repository/BareTasksAndEventsRepository.java
Show resolved
Hide resolved
...droid/src/main/java/expo/modules/taskManager/repository/ManagedTasksAndEventsRepository.java
Outdated
Show resolved
Hide resolved
...ager/android/src/main/java/expo/modules/taskManager/repository/TasksAndEventsRepository.java
Outdated
Show resolved
Hide resolved
tsapeta
approved these changes
May 28, 2020
tsapeta
approved these changes
May 28, 2020
Co-authored-by: Tomasz Sapeta <1714764+tsapeta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
If an application is being ejected, and some user updates its previously standalone (managed) application to ejected one, crash is observed when attempting to use AppLoader. Additionally, simple fix to prevent the crash causes helps, but tasks are not being transferred between versions correctly.
How
Root cause of the problem is the fact, that name of explicit AppLoader class implementation is persisted in SharedPreferences. At the same time, it differs between managed and bare workflow.
Current implementation defines names of loader in meta-data. This should cause it to be changed accordingly when migrating from managed to bare workflow.