New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @react-native-community/[picker|slider] #8451
Conversation
"firebase": "7.9.0" | ||
"firebase": "7.9.0", | ||
"@react-native-community/picker": "1.5.1", | ||
"@react-native-community/slider": "3.0.0-rc.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this make its way from RC to a "final" version in the next couple of days? Otherwise unless there are serious issues with 2.x I think we should prefer the stable version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i would go for 2.x if not. i have pinged the owners of this library on discord a couple times. my concern if we go with 2.x is that it doesn't have web support that @EvanBacon added, so i'm hoping that they will land 3.0 proper soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving contingent on 3.x being ready (or at least committing to only changes to the public JS API).
Update: there were a couple of pending PRs that slider maintainers wanted to land before releasing, I pushed those through so hopefully on Tuesday we will be able to merge this. |
…not in root of repo
df77a40
to
418ea4c
Compare
Merging with intent to update to @react-native-community/slider@3.0.0 asap |
Why
They're on a deprecation path from core and they are very useful components!
How
Added import script, imported them, added docs pages, updated NCL.
Test Plan
Test them in NCL:
TODO
Fix NCL on web - need to make sure we import Picker from react-native always on web. Bonus: open PR on Picker so it imports from react-native on web until they implement this.@EvanBacon reviewed and landed a PR upstream for Picker so we are good to go here.