Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @react-native-community/[picker|slider] #8451

Merged
merged 7 commits into from May 27, 2020

Conversation

brentvatne
Copy link
Member

@brentvatne brentvatne commented May 23, 2020

Why

They're on a deprecation path from core and they are very useful components!

How

Added import script, imported them, added docs pages, updated NCL.

Test Plan

Test them in NCL:

  • iOS
  • Android
  • Web

TODO

  • Fix NCL on web - need to make sure we import Picker from react-native always on web. Bonus: open PR on Picker so it imports from react-native on web until they implement this. @EvanBacon reviewed and landed a PR upstream for Picker so we are good to go here.
  • Follow up on slider 3.0.0 proper being released and update this PR to use it.

"firebase": "7.9.0"
"firebase": "7.9.0",
"@react-native-community/picker": "1.5.1",
"@react-native-community/slider": "3.0.0-rc.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this make its way from RC to a "final" version in the next couple of days? Otherwise unless there are serious issues with 2.x I think we should prefer the stable version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i would go for 2.x if not. i have pinged the owners of this library on discord a couple times. my concern if we go with 2.x is that it doesn't have web support that @EvanBacon added, so i'm hoping that they will land 3.0 proper soon.

Copy link
Member

@ide ide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving contingent on 3.x being ready (or at least committing to only changes to the public JS API).

@brentvatne
Copy link
Member Author

Update: there were a couple of pending PRs that slider maintainers wanted to land before releasing, I pushed those through so hopefully on Tuesday we will be able to merge this.

@brentvatne brentvatne force-pushed the @brent/add-lean-core-libraries branch from df77a40 to 418ea4c Compare May 27, 2020 03:18
@github-actions
Copy link
Contributor

Native Component List for this branch is ready

@brentvatne
Copy link
Member Author

Merging with intent to update to @react-native-community/slider@3.0.0 asap

@brentvatne brentvatne merged commit 367ce55 into master May 27, 2020
@brentvatne brentvatne deleted the @brent/add-lean-core-libraries branch May 27, 2020 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants