New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[expo-camera] export useful types from CameraModule.types.ts #8457
[expo-camera] export useful types from CameraModule.types.ts #8457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jarvisluong! Could you also run yarn build
in expo-camera
directory and commit build files? expo_sdk
job on CI is failing because of source code not being in sync with build files 😉
@tsapeta Right! I forgot to do that. Just pushed the build output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it's looking good 🥇
However, I'm not sure about changes in yarn.lock
. Your changes shouldn't modify it.
@lukmccall Should I just revert the yarn.lock change? |
I believe so, yes. |
This reverts commit 9d52c42.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 🎉🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jarvisluong ! 😉
Why
The constants type such as CameraType, ImageType, ImageParameters, ... are useful to develop an app using expo-camera. An example use case can be: