Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-camera] export useful types from CameraModule.types.ts #8457

Merged
merged 5 commits into from May 25, 2020

Conversation

jarvisluong
Copy link
Contributor

Why

The constants type such as CameraType, ImageType, ImageParameters, ... are useful to develop an app using expo-camera. An example use case can be:

const [cameraType, setCameraType] = useState<CameraType>(Camera.Constants.Type.back) // More explicit and strict typing.

Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jarvisluong! Could you also run yarn build in expo-camera directory and commit build files? expo_sdk job on CI is failing because of source code not being in sync with build files 😉

@jarvisluong
Copy link
Contributor Author

@tsapeta Right! I forgot to do that. Just pushed the build output

@jarvisluong jarvisluong requested a review from tsapeta May 24, 2020 09:14
Copy link
Contributor

@lukmccall lukmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it's looking good 🥇
However, I'm not sure about changes in yarn.lock. Your changes shouldn't modify it.

@jarvisluong
Copy link
Contributor Author

@lukmccall Should I just revert the yarn.lock change?

@lukmccall
Copy link
Contributor

@lukmccall Should I just revert the yarn.lock change?

I believe so, yes.

This reverts commit 9d52c42.
@jarvisluong
Copy link
Contributor Author

@lukmccall Should I just revert the yarn.lock change?

I believe so, yes.

Done

Copy link
Contributor

@lukmccall lukmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🎉🥇

Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jarvisluong ! 😉

@tsapeta tsapeta merged commit 0cd9191 into expo:master May 25, 2020
@jarvisluong jarvisluong deleted the feature/expo-camera-update-export branch May 25, 2020 20:44
prakashbask pushed a commit to prakashbask/expo that referenced this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants