Update react-native-safe-area-context #8459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
ide
approved these changes
May 23, 2020
brentvatne
force-pushed
the
@brent/update-safe-area-context
branch
from
9bcd7c4
to
d54cc09
Compare
prakashbask
pushed a commit
to prakashbask/expo
that referenced
this pull request
Mar 16, 2022
* Update react-native-safe-area-context * Update NCL and docs * Include all necessary files and add UIKit header import to get it to compile * Update home and expo pkg to use SafeAreaView from react-native-safe-area-context * Update dev home
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This is a dependency of react-navigation and we want to be sure we're on the latest version to be able to proceed with using it there. Also, the latest version fixes some bugs and adds support for a
SafeAreaViewcomponent that works cross-platform and effectively removes the need for thereact-native-safe-area-viewpackage.How
Import via script, add to NCL and docs, test on iOS, Android, and web in home and NCL.
This PR also adds
react-native-safe-area-contextas a dependency ofexpobecause we use it in ourDevContainerViewnow instead of the react-native SafeAreaView. This fixes an issue where the "Refreshing" popover would sometimes appear to vibrate/jitter around.Test Plan
Manually test in home and NCL.
Note: Android unit test failure is unrelated to this PR, it is caused by 34808ad. I commented out the offending code on my local branch in order to test this feature.