[ios] Update react-native-safe-area-context to 2.0.1 #8479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
tsapeta
force-pushed
the
@tsapeta/update-safe-area-context
branch
from
6e3d5ae
to
0bd19cf
Compare
brentvatne
approved these changes
May 25, 2020
|
test failure is unrelated, lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Upgrade 3rd party lib for SDK38
How
Ran
et update-module -m react-native-safe-area-context -c 25dd3324e858e152bb8dd2270b05764a653dad94and then gotUnknown type name 'UIEdgeInsets'build error so I've just addedUIKitimport in that header and submitted a PR fixing this: th3rdwave/react-native-safe-area-context#86Test Plan
Tested in NCL ✅