[expo-firebase-analytics] Updates Regex To Allow Numeric Chars #8516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IjzerenHein
suggested changes
May 28, 2020
- pulled out logic into isValidName - added more tests
IjzerenHein
reviewed
May 28, 2020
|
@IjzerenHein - updated and added a |
IjzerenHein
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The
eventNameanduserPropertyNamefor a firebase event support alphanumeric values but the regex was not allowing numeric characters.How
Updates regex and adds additional check to ensure the first char is alphabetic.
Test Plan
Added unit tests with expected results. Saw them fail. Updated logic and now they pass.