Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unimodules/core] Fix AppDelegate swift bug #8526

Merged
merged 2 commits into from May 28, 2020

Conversation

EvanBacon
Copy link
Contributor

Why

This bug prevents people from using a AppDelegate.swift in their unimodules app.
Full break down: https://github.com/unimodules/react-native-unimodules/issues/63#issuecomment-634980907

@EvanBacon EvanBacon added the bug label May 27, 2020
@EvanBacon EvanBacon requested a review from tsapeta as a code owner May 27, 2020 23:22
@EvanBacon EvanBacon self-assigned this May 27, 2020
@github-actions
Copy link
Contributor

Native Component List for this branch is ready

@EvanBacon EvanBacon merged commit 2ca2fbc into master May 28, 2020
@EvanBacon EvanBacon deleted the @evanbacon/unimodules/core/fix-swift-app-delegates branch May 28, 2020 18:09
@CesarLanderos
Copy link

Any idea when this is going to land on a release?

@tsapeta
Copy link
Member

tsapeta commented Jun 5, 2020

Hopefully I can get to it and publish it later today or if not then on Monday. I'll let you know here 🙂

@CesarLanderos
Copy link

I just upgraded to version 0.10.1 and all other dependencies to their most recent version, it all works now!, but, I noticed that it is tagged as a next version, we tested the features we are using from expo and seem to be working so far, but I'll keep an eye for the next public latest release, thank you so much for fixing this 🙇

@tsapeta
Copy link
Member

tsapeta commented Jun 11, 2020

@CesarLanderos Great it works now 😉 Yeah, they're published as next – we do this by default, we promote them to latest once we're sure everything works well. Usually it takes less time to promote them, but because we're releasing a new SDK right now we also do more thorough testing and QA 🙂 So don't worry, you can use next releases – we just don't want them to be installed by default yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants