Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-permissions] Fix notification requster #8539

Conversation

lukmccall
Copy link
Contributor

Why

Fixes #8536.

How

This permission shouldn't be always granted.

Test Plan

  • the demo included in issue work as expected.

@github-actions
Copy link
Contributor

Native Component List for this branch is ready

@lukmccall lukmccall merged commit cfd7c80 into master May 28, 2020
@lukmccall lukmccall deleted the @lukmccall/expo-permissions/fix-notification-requester-on-android branch May 28, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ANDROID] Permissions.askAsync(Permissions.NOTIFICATIONS) does not show notification modal
2 participants