Skip to content

Commit 95084fb

Browse files
committedFeb 17, 2024
Remove redundant operator override check
1 parent 8ecb18a commit 95084fb

File tree

2 files changed

+0
-32
lines changed

2 files changed

+0
-32
lines changed
 

‎checker/checker.go

-8
Original file line numberDiff line numberDiff line change
@@ -238,14 +238,6 @@ func (v *checker) BinaryNode(node *ast.BinaryNode) (reflect.Type, info) {
238238
l = deref.Type(l)
239239
r = deref.Type(r)
240240

241-
// check operator overloading
242-
if fns, ok := v.config.Operators[node.Operator]; ok {
243-
t, _, ok := conf.FindSuitableOperatorOverload(fns, v.config.Types, v.config.Functions, l, r)
244-
if ok {
245-
return t, info{}
246-
}
247-
}
248-
249241
switch node.Operator {
250242
case "==", "!=":
251243
if isComparable(l, r) {

‎checker/checker_test.go

-24
Original file line numberDiff line numberDiff line change
@@ -714,30 +714,6 @@ func TestCheck_AllowUndefinedVariables_OptionalChaining(t *testing.T) {
714714
assert.NoError(t, err)
715715
}
716716

717-
func TestCheck_OperatorOverload(t *testing.T) {
718-
type Date struct{}
719-
env := map[string]any{
720-
"a": Date{},
721-
"b": Date{},
722-
"add": func(a, b Date) bool {
723-
return true
724-
},
725-
}
726-
tree, err := parser.Parse(`a + b`)
727-
require.NoError(t, err)
728-
729-
config := conf.New(env)
730-
expr.AsBool()(config)
731-
732-
_, err = checker.Check(tree, config)
733-
require.Error(t, err)
734-
require.Contains(t, err.Error(), "invalid operation: + (mismatched types checker_test.Date and checker_test.Date)")
735-
736-
expr.Operator("+", "add")(config)
737-
_, err = checker.Check(tree, config)
738-
require.NoError(t, err)
739-
}
740-
741717
func TestCheck_PointerNode(t *testing.T) {
742718
_, err := checker.Check(&parser.Tree{Node: &ast.PointerNode{}}, nil)
743719
assert.Error(t, err)

0 commit comments

Comments
 (0)
Please sign in to comment.