Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debugger to show correct name for concat() #567

Open
antonmedv opened this issue Feb 17, 2024 · 0 comments
Open

Fix debugger to show correct name for concat() #567

antonmedv opened this issue Feb 17, 2024 · 0 comments
Labels

Comments

@antonmedv
Copy link
Member

❯ concat(1..2, 3..4)
[1 2 3 4]
❯ opcodes
0  OpPush  <0>  1
1  OpPush  <1>  2
2  OpRange
3  OpPush  <2>  3
4  OpPush  <3>  4
5  OpRange
6  OpPush      <4>  0x10031fca0
7  OpCallSafe  <2>

As we pushed "Safe" function into constants instead of functions.

What we can do:

  1. Add additional param "hash" for addConstant() so we can deduplicate on this hash param.
  2. Add opcode comments to display an arbitrary line as a comment per opcode (replace ".debugInfo").
@antonmedv antonmedv added the bug label Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant