Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Improve and cleanup TypeScript typings #231

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

WIP: Improve and cleanup TypeScript typings #231

wants to merge 2 commits into from

Conversation

mormahr
Copy link
Member

@mormahr mormahr commented Mar 21, 2021 •
edited

Fixes #230

@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2021 •
edited

⚠️ No Changeset found

Latest commit: efa4ffc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mormahr mormahr mentioned this pull request Mar 21, 2021
Open
@mormahr
Cleanup and modernize TypeScript handling
49ecde5 
Colocate typings with source file.
Add a strict tsconfig.json for the TypeScript test case.
Fix test case path.
@mormahr
Add failing test case for typescript-eslint
efa4ffc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type definitions are wrong, don't allow Promise to be returned (caught by @typescript-eslint)
1 participant
@mormahr