Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is args ? #202

Open
ilhamsj opened this issue Feb 19, 2024 · 3 comments
Open

What is args ? #202

ilhamsj opened this issue Feb 19, 2024 · 3 comments

Comments

@ilhamsj
Copy link

ilhamsj commented Feb 19, 2024

Description

Some people may not understand this part.
sendCommand: (...args: string[]) => client.sendCommand(args),

Why

some people may not understand args part.

Alternatives

please add more detail description can use rate-limit-mongo for reference

@nfriedly
Copy link
Member

Yeah, that's a fair point. args is an array containing the command and any values that rate-limit-redis passes to the database driver.

I'd like to put out an updated version of this library that has a default redis driver built-in, so that the whole sendCommand thing is unnecessary for basic usage, which should reduce that confusion.

@moohbr
Copy link

moohbr commented Feb 20, 2024

@nfriedly did want some help to do it? I have some free time until my colleague starts.

@nfriedly
Copy link
Member

nfriedly commented Feb 20, 2024

Sure! I just filed #203 with my thinking. I'd be interested in hearing if @wyattjoh or @gamemaker1 had any thoughts on the idea also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants