Request-level bail #1214
Merged
Request-level bail #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavohenke
commented
Feb 18, 2023
| @@ -62,12 +69,25 @@ export function oneOf( | |||
| const middleware = async (req: InternalRequest, _res: any, next: (err?: any) => void) => { | |||
| const surrogateContext = new ContextBuilder().addItem(dummyItem).build(); | |||
|
|
|||
| // Run each group of chains in parallel, and within each group, run each chain in parallel too. | |||
There was a problem hiding this comment.
This is a perf loss, but I don't see any other way of implementing this.
There was a problem hiding this comment.
Latest version is better, but still a perf loss. I've added a summary of changes to the PR description.
Closed
gustavohenke
commented
Mar 5, 2023
Closed
gustavohenke
force-pushed
the
v7-request-bail
branch
from
fe2e984
to
7eaab8e
Compare
gustavohenke
added a commit
that referenced
this pull request
Mar 11, 2023
gustavohenke
added a commit
that referenced
this pull request
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1100
Implements an option to
.bail()so that no further contexts will run if there are any errors.Supports:
oneOfcheckSchemacheckExactSuppose that you have a request with 1k fields, one validator on each field, each taking 10ms to complete.
Also suppose that no fields present errors, so every validator runs.
On my machine, the time it takes for running all validation chains looks like this:
To-do list