doc: update var to const in all Readmes #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, I think you are right, I'm open to changing it 👍 |
nevilm-lt
pushed a commit
to nevilm-lt/multer
that referenced
this pull request
Apr 21, 2022
doc: update var to const in all Readmes
nevilm-lt
pushed a commit
to nevilm-lt/multer
that referenced
this pull request
Apr 22, 2022
doc: update var to const in all Readmes
nevilm-lt
pushed a commit
to nevilm-lt/multer
that referenced
this pull request
Apr 22, 2022
doc: update var to const in all Readmes
himanshiLt
pushed a commit
to himanshiLt/multer
that referenced
this pull request
Apr 26, 2022
doc: update var to const in all Readmes
himanshiLt
pushed a commit
to himanshiLt/multer
that referenced
this pull request
Jun 24, 2022
doc: update var to const in all Readmes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
vartoconstin Readme and all translations. This was done with a search replace on each document, I believe but did not verify that all code examples are the same in all translations.Interestingly though, I think the English readme might have an extra codeblock that the others don't. Someone should check the blame and see if we need to update the translations with an example. Although I guess we would then need to translate that example haha.
Edit: Found it and it's of course something I reviewed. Looking back at it, I'm not sure that example was necessary. I think it just repeats the example above it. Maybe the elaborated explanation should get moved up.
closes #1012