Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: replace deprecated pseudoRandomBytes with randomBytes #774

Merged
merged 1 commit into from
Mar 8, 2020

Conversation

gireeshpunathil
Copy link
Contributor

@gireeshpunathil gireeshpunathil commented Sep 17, 2019

Fixes: #509
Fixes: #811

cc @LinusU

@gireeshpunathil
Copy link
Contributor Author

bump. Is there anything I can help with, to move this forward? two issues waiting on this. thanks!

@geoynomous
Copy link

it might be delayed, as older versions of node do not have that function?

@gireeshpunathil
Copy link
Contributor Author

that depends; on :

  • which version of multer this is going to be cut into
  • which version of node that version multer is going to support

@LinusU
Copy link
Member

LinusU commented Mar 8, 2020

Sorry for not getting to this!

crypto.randomBytes is supported on Node.js 0.10 which is what Multer 1.x is supporting, so there should be no problem merging this 👍

@LinusU LinusU merged commit 0f3c47b into expressjs:master Mar 8, 2020
@geoynomous
Copy link

Is there also a 2.0 release coming?

nevilm-lt pushed a commit to nevilm-lt/multer that referenced this pull request Apr 21, 2022
…mbytes

storage: replace deprecated pseudoRandomBytes with randomBytes
nevilm-lt pushed a commit to nevilm-lt/multer that referenced this pull request Apr 21, 2022
…mbytes

storage: replace deprecated pseudoRandomBytes with randomBytes
nevilm-lt pushed a commit to nevilm-lt/multer that referenced this pull request Apr 22, 2022
…mbytes

storage: replace deprecated pseudoRandomBytes with randomBytes
nevilm-lt pushed a commit to nevilm-lt/multer that referenced this pull request Apr 22, 2022
…mbytes

storage: replace deprecated pseudoRandomBytes with randomBytes
nevilm-lt pushed a commit to nevilm-lt/multer that referenced this pull request Apr 22, 2022
…mbytes

storage: replace deprecated pseudoRandomBytes with randomBytes
himanshiLt pushed a commit to himanshiLt/multer that referenced this pull request Jun 24, 2022
…mbytes

storage: replace deprecated pseudoRandomBytes with randomBytes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crypto.pseudoRandomBytes is deprecated Usage of deprecated function crypto.pseudoRandomBytes
3 participants