Add Math.random() to storage filename example #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was encountering an issue where two files had the same name due to being handled in the same millisecond. While not a bug, adding extra uniqueness may save someone else time troubleshooting 'missing' files.
LinusU
reviewed
Feb 17, 2020
README.md
Outdated
| @@ -175,7 +175,7 @@ var storage = multer.diskStorage({ | |||
| cb(null, '/tmp/my-uploads') | |||
| }, | |||
| filename: function (req, file, cb) { | |||
| cb(null, file.fieldname + '-' + Date.now()) | |||
| cb(null, file.fieldname + '-' + Date.now() + '-' + Math.random()) | |||
There was a problem hiding this comment.
Hmm, this will produce filenames like: foo-1581931472193-0.5359727197825674. I'm not sure how that is being handled since essentially the file extension of the file is now .5359727197825674 🤔
|
In linux there's no problem, but you are correct that Windows will
probably scream. I'll edit to remove the period.
…On Mon, Feb 17, 2020, 4:26 AM Linus Unnebäck ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<#841 (comment)>:
> @@ -175,7 +175,7 @@ var storage = multer.diskStorage({
cb(null, '/tmp/my-uploads')
},
filename: function (req, file, cb) {
- cb(null, file.fieldname + '-' + Date.now())
+ cb(null, file.fieldname + '-' + Date.now() + '-' + Math.random())
Hmm, this will produce filenames like:
foo-1581931472193-0.5359727197825674. I'm not sure how that is being
handled since essentially the file extension of the file is now
.5359727197825674 🤔
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#841?email_source=notifications&email_token=AABOUCU4DXFBQVOXNCYVSP3RDJJ2RA5CNFSM4KWGLCI2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVXOMII#pullrequestreview-359589409>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABOUCXQS4WFD3DOB5A7NGTRDJJ2RANCNFSM4KWGLCIQ>
.
|
LinusU
reviewed
Feb 17, 2020
README.md
Outdated
| @@ -175,7 +175,8 @@ var storage = multer.diskStorage({ | |||
| cb(null, '/tmp/my-uploads') | |||
| }, | |||
| filename: function (req, file, cb) { | |||
| cb(null, file.fieldname + '-' + Date.now()) | |||
| const uniqueHash = Date.now() + '-' + Math.random().split('.')[1] | |||
There was a problem hiding this comment.
Can we call this something other than "hash" since it isn't a hash?
There was a problem hiding this comment.
Math.random().split('.')[1] this will throw an error:
TypeError: Math.random(...).split is not a function
jonchurch
reviewed
Feb 18, 2020
LinusU
reviewed
Feb 18, 2020
README.md
Outdated
| @@ -175,8 +175,8 @@ var storage = multer.diskStorage({ | |||
| cb(null, '/tmp/my-uploads') | |||
| }, | |||
| filename: function (req, file, cb) { | |||
| const uniqueHash = Date.now() + '-' + Math.random().split('.')[1] | |||
| cb(null, file.fieldname + '-' + uniqueHash) | |||
| const uniqueSuffix = Date.now() + '_' + (Math.random().toString().split('.')[1]) | |||
There was a problem hiding this comment.
What do you think about Math.round(Math.random() * 1E9) instead of (Math.random().toString().split('.')[1]), I feel that it's a bit easier to understand?
There was a problem hiding this comment.
If that works, I'm ok with it.
LinusU
reviewed
Feb 18, 2020
README.md
Outdated
| @@ -175,8 +175,8 @@ var storage = multer.diskStorage({ | |||
| cb(null, '/tmp/my-uploads') | |||
| }, | |||
| filename: function (req, file, cb) { | |||
| const uniqueHash = Date.now() + '-' + Math.random().split('.')[1] | |||
| cb(null, file.fieldname + '-' + uniqueHash) | |||
| const uniqueSuffix = Date.now() + '_' + (Math.random().toString().split('.')[1]) | |||
There was a problem hiding this comment.
I've run into issues where Javascript sees a dash and tries to do math. I figured it was safer, but i can change it back if you want.
LinusU
reviewed
Feb 18, 2020
LinusU
approved these changes
Feb 18, 2020
|
Great, thanks! |
nevilm-lt
pushed a commit
to nevilm-lt/multer
that referenced
this pull request
Apr 21, 2022
* Add Math.random() to storage filename example I was encountering an issue where two files had the same name due to being handled in the same millisecond. While not a bug, adding extra uniqueness may save someone else time troubleshooting 'missing' files. * Remove the period from the hash * Convert to string and split. Also rename * Update README.md * Math.round(Math.random() * 1E9) and revert dashes
nevilm-lt
pushed a commit
to nevilm-lt/multer
that referenced
this pull request
Apr 21, 2022
* Add Math.random() to storage filename example I was encountering an issue where two files had the same name due to being handled in the same millisecond. While not a bug, adding extra uniqueness may save someone else time troubleshooting 'missing' files. * Remove the period from the hash * Convert to string and split. Also rename * Update README.md * Math.round(Math.random() * 1E9) and revert dashes
nevilm-lt
pushed a commit
to nevilm-lt/multer
that referenced
this pull request
Apr 22, 2022
* Add Math.random() to storage filename example I was encountering an issue where two files had the same name due to being handled in the same millisecond. While not a bug, adding extra uniqueness may save someone else time troubleshooting 'missing' files. * Remove the period from the hash * Convert to string and split. Also rename * Update README.md * Math.round(Math.random() * 1E9) and revert dashes
nevilm-lt
pushed a commit
to nevilm-lt/multer
that referenced
this pull request
Apr 22, 2022
* Add Math.random() to storage filename example I was encountering an issue where two files had the same name due to being handled in the same millisecond. While not a bug, adding extra uniqueness may save someone else time troubleshooting 'missing' files. * Remove the period from the hash * Convert to string and split. Also rename * Update README.md * Math.round(Math.random() * 1E9) and revert dashes
nevilm-lt
pushed a commit
to nevilm-lt/multer
that referenced
this pull request
Apr 22, 2022
* Add Math.random() to storage filename example I was encountering an issue where two files had the same name due to being handled in the same millisecond. While not a bug, adding extra uniqueness may save someone else time troubleshooting 'missing' files. * Remove the period from the hash * Convert to string and split. Also rename * Update README.md * Math.round(Math.random() * 1E9) and revert dashes
himanshiLt
pushed a commit
to himanshiLt/multer
that referenced
this pull request
Jun 24, 2022
* Add Math.random() to storage filename example I was encountering an issue where two files had the same name due to being handled in the same millisecond. While not a bug, adding extra uniqueness may save someone else time troubleshooting 'missing' files. * Remove the period from the hash * Convert to string and split. Also rename * Update README.md * Math.round(Math.random() * 1E9) and revert dashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was encountering an issue where two files had the same name due to being handled in the same millisecond. While not a bug, adding extra uniqueness may save someone else time troubleshooting 'missing' files.