Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump mkdirp version #862

Merged
merged 1 commit into from
Apr 24, 2020
Merged

bump mkdirp version #862

merged 1 commit into from
Apr 24, 2020

Conversation

jonchurch
Copy link
Member

@jonchurch jonchurch commented Mar 26, 2020

A new version of mkdirp's 0.x line has fixed the #139 infinite loop on windows issue

I do not know what the deal is with the one failing test on CI

@jonchurch
Copy link
Member Author

jonchurch commented Mar 31, 2020

Bumping this bump, getting a patch out will also allow folks to silence the minimist npm audit warning with just an npm update multer. #865 #859

@dougwilson
Copy link
Contributor

The CI failure is a bug in the installed version of standard. It thinks it works of Node.js 4, but it does not, due to a dep breaking it.

@LinusU
Copy link
Member

LinusU commented Apr 23, 2020

@jonchurch would you mind pushing a commit that bumps standard to the latest version as well? That should fix the CI breakage ☺️

@dougwilson
Copy link
Contributor

@LinusU #878 👍

@LinusU
Copy link
Member

LinusU commented Apr 24, 2020

Thanks @jonchurch and @dougwilson ❤️

@LinusU LinusU merged commit 6fd38ed into expressjs:master Apr 24, 2020
nevilm-lt pushed a commit to nevilm-lt/multer that referenced this pull request Apr 21, 2022
nevilm-lt pushed a commit to nevilm-lt/multer that referenced this pull request Apr 22, 2022
nevilm-lt pushed a commit to nevilm-lt/multer that referenced this pull request Apr 22, 2022
himanshiLt pushed a commit to himanshiLt/multer that referenced this pull request Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants