Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why does this library require Node >= 16.x.x? #32

Closed
mattseddon opened this issue Nov 23, 2021 · 4 comments
Closed

Question: Why does this library require Node >= 16.x.x? #32

mattseddon opened this issue Nov 23, 2021 · 4 comments

Comments

@mattseddon
Copy link

Tl;Dr - why does this library need Node >= 16.x.x?.

Hi,

I am currently working on a VS Code extension for DVC. To give you some context DVC is a CLI for (not just) Data Version Control in Machine Learning Projects. The CLI is written in Python and the extension is written in Typescript then bundled and run inside of VS Code (which is an Electron app). I am currently looking to improve the integration between the CLI and the extension.

At the moment we use execa to create child_processes which run the CLI as a black box and return JSON. We then parse that JSON and feed it through the extension.

Not being able to access the internals of the Python project has started to become an issue so we have been looking for alternatives. This looks like a solid library but unfortunately, the VS Code Electron app runs on Node 14.17.0 and as far as I am aware there are no plans to change this in the short to medium term.

What would need to be done to make this library compatible with an earlier version of Node? Is that even possible?

Thanks,
Matt

@extremeheat
Copy link
Owner

in #33:

I believe the main issue with node 14 was with the javascript pip package where the event emitter handling code changed in node 15/16 causing the behavior on the Python side to be different. It was fixed with a patch here. I don't think the issue is present on the pythonia package as we don't do event emitter handling there, so yeah doesn't seem like there's any other blocking issue for node 16.

so once we merge that we can probably do a release if everything looks good

@mattseddon
Copy link
Author

Thank you both.

@extremeheat
Copy link
Owner

Fixed in #33 and released as 0.2.13

@mattseddon
Copy link
Author

Thanks, I'll come back and let you know how everything goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants