Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Overrides via Environment #914

Closed
wants to merge 8 commits into from
Closed

Icon Overrides via Environment #914

wants to merge 8 commits into from

Conversation

gierens
Copy link
Member

@gierens gierens commented Mar 30, 2024

This adds setting custom icons via a new environment variable EZA_ICONS. At the root this works with a HashMap<String, char> in UiStyles.custom_icons which is accessed in FileName.paint via FileNameColours.custom_icons.

Screenshot from 2024-03-30 18-04-22

This is still very rudimentary, only handles extensions, no docs, no tests, just to get things rolling, thus the draft.

Resolves #909

Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Resolves #909

Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
@gierens gierens added enhancement New feature or request features › icon features › ui rust Pull requests that update Rust code labels Mar 30, 2024
@gierens
Copy link
Member Author

gierens commented Mar 30, 2024

Doesn't really seem to hit performance, at least not according to my very rigorous and detailed studies :D

Screenshot from 2024-03-30 18-18-41

Still ⚡ blazingly ⚡ fast :D

gierens added a commit to PThorpe92/eza that referenced this pull request Mar 31, 2024
This basically ports the PR eza-community#914 and thus also resolves eza-community#909

Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
@gierens
Copy link
Member Author

gierens commented Mar 31, 2024

I ported this to #840 so this functionality will be merged there thus I'm closing this PR.

@gierens gierens closed this Mar 31, 2024
hasecilu pushed a commit to hasecilu/eza that referenced this pull request Apr 7, 2024
This basically ports the PR eza-community#914 and thus also resolves eza-community#909

Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
hasecilu pushed a commit to hasecilu/eza that referenced this pull request Apr 7, 2024
This basically ports the PR eza-community#914 and thus also resolves eza-community#909

Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request features › icon features › ui rust Pull requests that update Rust code
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

feat: LS_ICONS for icon overrides
1 participant