Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: pr template isn't auto-populated #969

Open
CouldBeThis opened this issue May 6, 2024 · 2 comments
Open

bug: pr template isn't auto-populated #969

CouldBeThis opened this issue May 6, 2024 · 2 comments

Comments

@CouldBeThis
Copy link
Contributor

In CONTRIBUTING.md > "Creating a PR":

First, use the pull request template.

Eventually I found the file located at https://github.com/eza-community/eza/blob/main/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md. You need to view raw to see most of the content as it is comments.

Maybe it should be linked from CONTRIBUTING.md? Kind of hard to find.

Is it supposed to be auto populating the PR text entry box? It didn't for me.

@cafkafk
Copy link
Member

cafkafk commented May 7, 2024

Is it supposed to be auto populating the PR text entry box? It didn't for me.

Yea, is should... it does so for me, at least last time I tried IIRC. Of course, if it doesn't, that's a bug!

@cafkafk cafkafk changed the title PR template is hard to find bug: pr template isn't auto-populated May 7, 2024
@CouldBeThis
Copy link
Contributor Author

Well if at least one other person is unable to duplicate then I guess I should first rule out dumb user error.

Since I was making only very basic changes and the device I was using isn't really set up properly for terminal stuff, I did everything via the web interface.

Steps to reproduce

Everything using only the most basic web github.com:

  1. Create a fork, edit the readme (nothing more fancy). Commit etc.

  2. Go to the webpage of fork, eg: https://github.com/CouldBeThis/eza and click Contribute > Open pull request:

screenshot

image

  1. Directed to main...CouldBeThis:eza:main click Create pull request:
screenshot

image

  1. Directed to main...CouldBeThis:eza:main where I see this PR box.
screenshot

image

potential issues

  • Did I make some error up there?

  • I deviated substantially from the CONTRIBUTING.MD by not setting up the dev environment, running tests, etc. It is not necessary to prettyup a markdown. Is the PR template somehow related to all that?

If someone could send me toward another repo(s) they know of with issue templates that auto populate, I will try them and see if it's a global situation or just this repo.


PS: I'm only posting this in case there is a problem with the software/systems. Just a rec league PRer here and I do not want to waste a bunch of your times coaching me how to use github etc. If it's user error, it's user error. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants