Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for django-rosetta Package #340

Open
Farhaduneci opened this issue Dec 20, 2023 · 1 comment
Open

Adding Support for django-rosetta Package #340

Farhaduneci opened this issue Dec 20, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Farhaduneci
Copy link

Farhaduneci commented Dec 20, 2023

Hey there,
Thanks so much for all your work on this repo! I really appreciate you contributing to Django.

I would like to propose the addition of support for the django-rosetta package. I use this package alongside your project and inconsistent themes are kinda buggy.

I understand that adding support for new packages requires careful consideration and effort. I would be grateful if you could share some insight into the general process you follow when considering adding support for new packages. This information would be incredibly valuable as I am interested in contributing to the project and would like to understand how I could potentially assist in implementing this feature.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@Farhaduneci Farhaduneci added the enhancement New feature or request label Dec 20, 2023
@fabiocaccamo
Copy link
Owner

fabiocaccamo commented Dec 20, 2023

@Farhaduneci thank you for this suggestion, personally I don't use django-rosetta, so I don't think I will ever work on this issue until I will need it personally for a commercial project or this package will have some sponsors, but if you want to contribute feel free to submit a PR, I will be glad to review and merge it.

More generally regarding third-party packages support, it's quite impossible to support all the most popular admin packages and maintaining them well supported along the time.

I think that it would be nice if third-party packages would start to use some CSS rules prefixed by .admin-interface selector (so they will do nothing if this package is not used) in combination with CSS variables exposed by this package to improve their appereance when this package is used.

@fabiocaccamo fabiocaccamo changed the title Adding Support for "django-rosetta" Package Adding Support for django-rosetta Package Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants