Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support runtime healthcheck additions (including compose support) #1733

Open
poikilotherm opened this issue Dec 12, 2023 · 0 comments · May be fixed by #1736
Open

Support runtime healthcheck additions (including compose support) #1733

poikilotherm opened this issue Dec 12, 2023 · 0 comments · May be fixed by #1736
Assignees
@poikilotherm

Comments

@poikilotherm
Copy link
Contributor

poikilotherm commented Dec 12, 2023 •
edited

Description

Currently, a healthcheck can only be added to a container when building it. Existing of-the-shelve containers that are not supposed to be modified cannot be run with a healthcheck if not included by upstream image vendor. Defining healthchecks in / from Docker Compose files is not supported.

Info

  • docker-maven-plugin version : 0.43.4
  • Maven version (mvn -v) : 3.9.1
  • Docker version : Moby 25.0.0-beta.1, build 2b521e4
  • If it's a bug, how to reproduce : Not a bug
  • If it's a feature request, what is your use case : Add healthchecks for dependency containers to enable waiting for them to be read/healthy before starting an application container
  • Sample project : https://github.com/IQSS/dataverse.git

This is fallout from #888 / #1718. It is related to #1580 . PR forthcoming.
poikilotherm added a commit to poikilotherm/docker-maven-plugin that referenced this issue Dec 14, 2023
@poikilotherm
feat(config): enable provisioning healthchecks via <run><healthCheck>…
75ee5bd 
… configuration fabric8io#1733

Enable adding <healthCheck> XML declaration as seen in <build> sections before now also in <run>.
poikilotherm added a commit to poikilotherm/docker-maven-plugin that referenced this issue Dec 14, 2023
@poikilotherm
feat(config): validate healthcheck passed in run config fabric8io#1733
ce2901a
poikilotherm added a commit to poikilotherm/docker-maven-plugin that referenced this issue Dec 14, 2023
@poikilotherm
feat(config): wire healthcheck to Docker Create Container API wrapper f…
7957d09 
…abric8io#1733

Transforming the internal healthcheck model into a JSON object the Docker API understands when added to the larger create container JSON object.
poikilotherm added a commit to poikilotherm/docker-maven-plugin that referenced this issue Dec 14, 2023
@poikilotherm
feat(assembly): ensure users do not use healthcheck shell mode at bui…
d6f0a33 
…ld time fabric8io#1733

Technically, we reuse the HealthCheckConfiguration for both build and runtime added checks. Yet the syntax is slightly different: for runtime checks, we need to specify whether we want CMD or SHELL, for build time checks Docker figures that out itself.
@poikilotherm poikilotherm linked a pull request Dec 14, 2023 that will close this issue
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poikilotherm poikilotherm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Runtime healthcheck definition support poikilotherm/docker-maven-plugin
1 participant
@poikilotherm