Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogRequestor : Replace com.google.common.base.Charsets.UTF_8 with StandardCharsets.UTF_8 #1767

Open
2 tasks
rohanKanojia opened this issue Mar 1, 2024 · 5 comments
Assignees

Comments

@rohanKanojia
Copy link
Member

Description

LogRequestor is using Guava's Charset class which has been redundant since a similar class was added in JDK7 : StandardCharsets

String message = Charsets.UTF_8.newDecoder().decode(payload).toString();

Sonar reports this as a code smell. We should replace usage of this class with JDK provided equivalent.

Acceptance Criteria

  • Guava's Charset class is replaced with JDK's StandardCharsets
  • LogRequestorTest is also updated with similar change
@rohanKanojia
Copy link
Member Author

@mdxabu : Could you please check if this is clear enough for you? If yes, shall I assign it to you?

@Morbo-ui
Copy link

Morbo-ui commented Mar 2, 2024

Can I work on this one?

@mdxabu
Copy link
Contributor

mdxabu commented Mar 2, 2024

@mdxabu : Could you please check if this is clear enough for you? If yes, shall I assign it to you?

Ok, I'll work on that

@rohanKanojia
Copy link
Member Author

@Morbo-ui : Hello, Is it okay if I create some other issue for you? It seems like a PR already got created for this issue.

@Morbo-ui
Copy link

Morbo-ui commented Mar 2, 2024

@Morbo-ui : Hello, Is it okay if I create some other issue for you? It seems like a PR already got created for this issue.

Yeah no problem, just let me know what can I help with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants