Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResourceListTest.testCreateOrReplaceWithDeleteExisting flakiness #5953

Closed
shawkins opened this issue Apr 25, 2024 · 2 comments · Fixed by #6004
Closed

ResourceListTest.testCreateOrReplaceWithDeleteExisting flakiness #5953

shawkins opened this issue Apr 25, 2024 · 2 comments · Fixed by #6004
Assignees
@shawkins
Labels
technical-debt test
Milestone
6.13.0

Comments

@shawkins
Copy link
Contributor

https://github.com/fabric8io/kubernetes-client/actions/runs/8831445429/job/24246684439?pr=5949#step:4:73186 shows a failure with

ResourceListTest.testCreateOrReplaceWithDeleteExisting:178 expected: <6> but was: <7>

We'll need to double check if the condition should look for at least that many requests, not exactly.
@manusa
Copy link
Member

manusa commented Apr 25, 2024

It's been flaky for a while.

Maybe asserting the number of requests is not exactly what we want.

@manusa manusa added the test label May 2, 2024
@shawkins
Copy link
Contributor Author

The issue here is a race condition between stopping the reflector due to the condition being satisfied and starting the watch. If an attempt is made to start the watch you end up with a 7th request.

shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 13, 2024
@shawkins
fix: defer watch until the initial processing of list is complete
7702980 
closes: fabric8io#5953

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 13, 2024
@shawkins
fix: defer watch until the initial processing of list is complete
5d350f9 
closes: fabric8io#5953

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 13, 2024
@shawkins
fix: defer watch until the initial processing of list is complete
d8c6775 
closes: fabric8io#5953

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@shawkins shawkins mentioned this issue May 13, 2024
Merged
11 tasks
@shawkins shawkins self-assigned this May 13, 2024
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 20, 2024
@shawkins
fix: defer watch until the initial processing of list is complete
e0fe708 
closes: fabric8io#5953

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@manusa manusa added this to the 6.13.0 milestone May 21, 2024 — with automated-tasks
manusa pushed a commit that referenced this issue May 21, 2024
@shawkins
fix: defer watch until the initial processing of list is complete
c470c55 
closes: #5953

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
technical-debt test
Projects
None yet
Milestone
6.13.0
Development

Successfully merging a pull request may close this issue.

fix: defer watch until the initial processing of list is complete shawkins/kubernetes-client
2 participants
@manusa @shawkins