Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image filters demo is not working #213

Open
brandondong opened this issue Jul 7, 2018 · 7 comments
Open

Image filters demo is not working #213

brandondong opened this issue Jul 7, 2018 · 7 comments

Comments

@brandondong
Copy link
Contributor

http://fabricjs.com/image-filters

Selecting an image and applying a filter does nothing. Tested on chrome and firefox.

@ncou
Copy link

ncou commented Jul 8, 2018

I confirm the bug, it looks like a missing .render() because if you apply a filter the image is not modified, but if you force the refresh by scaling the image object, the filter is applyed.

By the way there is also an angular error in the Chrome/FF console.

@asturur
Copy link
Member

asturur commented Jul 8, 2018

i do think is the clipPath code i uploaded. Fabric image caching breaks the inages in general

@ncou
Copy link

ncou commented Jul 8, 2018

i think the sprite demo is also broken.

@asturur
Copy link
Member

asturur commented Jul 8, 2018

as of now on the website there is a version that is broken with images but is not 2.3.3.
I know i should not have uploaded it, but i wanted to show clipPath progress.
The download links point to the good one

@alexstulov
Copy link

Ubuntu 16.04
Works under Firefox 61.0.1 (64-bit)
Not work under Chrome Version 68.0.3440.84 (Official Build) (64-bit):
I see this output in console:
max texture size: 8192 MINERR_ASSET:22 Uncaught Error: [$injector:modulerr] http://errors.angularjs.org/1.2.6/$injector/modulerr?p0=kitchensink&p1=Error%3A%20%5B%24injector%3Anomod%5D%20http%3A%2F%2Ferrors.angularjs.org%2F1.2.6%2F%24injector%2Fnomod%3Fp0%3Dkitchensink%0A%20%20%20%20at%20https%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fangularjs%2F1.2.6%2Fangular.min.js%3A6%3A449%0A%20%20%20%20at%20https%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fangularjs%2F1.2.6%2Fangular.min.js%3A20%3A185%0A%20%20%20%20at%20https%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fangularjs%2F1.2.6%2Fangular.min.js%3A21%3A170%0A%20%20%20%20at%20https%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fangularjs%2F1.2.6%2Fangular.min.js%3A29%3A116%0A%20%20%20%20at%20Array.forEach%20(%3Canonymous%3E)%0A%20%20%20%20at%20q%20(https%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fangularjs%2F1.2.6%2Fangular.min.js%3A7%3A274)%0A%20%20%20%20at%20e%20(https%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fangularjs%2F1.2.6%2Fangular.min.js%3A29%3A56)%0A%20%20%20%20at%20Yb%20(https%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fangularjs%2F1.2.6%2Fangular.min.js%3A32%3A125)%0A%20%20%20%20at%20c%20(https%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fangularjs%2F1.2.6%2Fangular.min.js%3A17%3A394)%0A%20%20%20%20at%20Xb%20(https%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fangularjs%2F1.2.6%2Fangular.min.js%3A18%3A81) at MINERR_ASSET:22 at angular.js:3642 at Array.forEach (<anonymous>) at q (angular.js:302) at e (angular.js:3608) at Yb (angular.js:3548) at c (angular.js:1296) at Xb (angular.js:1311) at Rc (angular.js:1260) at angular.js:20534

@asturur
Copy link
Member

asturur commented Aug 11, 2018

if you disable webgl does it work?

@alexstulov
Copy link

Yes, it works with webgl disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants