Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demos(): Image.fromURL is broken #334

Open
ShaMan123 opened this issue Feb 28, 2022 · 8 comments
Open

demos(): Image.fromURL is broken #334

ShaMan123 opened this issue Feb 28, 2022 · 8 comments

Comments

@ShaMan123
Copy link
Contributor

All images loaded by url are broken

@asturur
Copy link
Member

asturur commented Mar 1, 2022

image

image proxy broken

@ShaMan123
Copy link
Contributor Author

ShaMan123 commented Mar 3, 2022

https://docs.github.com/en/pages/getting-started-with-github-pages/securing-your-github-pages-site-with-https

I don't nave access to settings
This might be the solution

@asturur
Copy link
Member

asturur commented Mar 3, 2022

we used the image proxy when we added codepens because fabricjs.com does not offer an https option. I can check if something is changed but could be negative

@ShaMan123
Copy link
Contributor Author

I understand, that's why enforcing https might fix this issue and is a natural move forward anyways

@asturur
Copy link
Member

asturur commented Mar 3, 2022

last time i checked on custom domain that is not possible anymore

@ShaMan123
Copy link
Contributor Author

And adding certificate manually? via the domain provider?

@ShaMan123
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants