Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low priority: Custom builds require 'Animation' to be checked #339

Open
joevallender opened this issue Mar 30, 2022 · 1 comment
Open

Low priority: Custom builds require 'Animation' to be checked #339

joevallender opened this issue Mar 30, 2022 · 1 comment

Comments

@joevallender
Copy link
Contributor

I'm using Fabric for part of an app that requires very limited dragging and rotation of images across desktop and mobile so I headed to http://fabricjs.com/build/ to include the gestures and slim the file size down a bit.

The resulting build kept throwing an error relating to fabric.util.requestAnimFrame despite me only using Gestures/Interaction/fabric.Image. I tried a build with Animation checked and it was okay. No big deal in my use case. However I thought I'd flag it.

Also that page says its building v4.1.0 but its actually outputting v5.2.0

I'll take a quick look at a PR to the text on /build/

@asturur
Copy link
Member

asturur commented Mar 30, 2022

it could be that requestRenderAll uses that, in case we should move requestAnimFrame outside the util module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants